Problem/Motivation

Creating new media type doesn't have default entity view mode configuration available.

Steps to reproduce

  • Site install with acquia_dam version 1.0.x/1.1.x
  • Create new media type with name "Test" and select any media source provided by acquia_dam module
  • Visit media type manage display: admin/structure/media/manage/test/display/media_library
  • See content region thumbnail field is available instead of Asset Reference

Proposed resolution

Update media_library view display to have Asset reference field with format Embed code and embed_style Thumbnail image of the finalized asset version, or the alternate preview if set.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork acquia_dam-3515288

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rajeshreeputra created an issue. See original summary.

rajeshreeputra opened merge request !139

ankitv18’s picture

ankitv18 commented
Status: Active » Needs work

Added comments in the MR

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Status: Needs work » Needs review

japerry made their first commit to this issue’s fork.

japerry opened merge request !146

japerry’s picture

japerry
Location KOMK
commented
Status: Needs review » Needs work

MR139 overcomplicates the addition of the media library. Honestly, the swaping fields from 1.1.0 is also a little too complex and could also be simplified, but not sure thats needed for this issue.

The MR below is a much simpler approach. You -almost- could put this in the asset and not need it in the derivative plugin, but that'd commit us to never needing a different media library field formatter for different types.

https://git.drupalcode.org/project/acquia_dam/-/merge_requests/146

rajeshreeputra changed the visibility of the branch 3515288-create-media-displays to hidden.

rajeshreeputra changed the visibility of the branch 3515288-create-media-displays to active.

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Status: Needs work » Needs review

Updated MR!139 with review feedback. Rebase completed with 1.1.x branch. Hence requesting review.

japerry’s picture

japerry
Location KOMK
commented
Status: Needs review » Fixed

Awesome looks good. Merged.

japerry changed the visibility of the branch 3515288-create-media-displays to hidden.

japerry closed merge request !146

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Category: Bug report » Support request