Problem/Motivation

1. This use of the FilterPlugin does not provide the configuration of `civictheme_rich_text` and so converts all emails to links whether or not we want to.

Proposed resolution

1. Investigate why we are using FilterPlugin directly and not relying on text_format preprocessing.

This was caused by fixing this: https://www.drupal.org/node/3415687

CommentFileSizeAuthor
#10 urlsAndLinks2.png940.45 KBdanielgry
#10 ckeditor-settings2.png166.68 KBdanielgry
#10 themeSettings.png176 KBdanielgry
#10 emailAndLinks.png864 KBdanielgry
#10 ckeditor-settings1.png240.79 KBdanielgry

Comments

richardgaunt created an issue. See original summary.

richardgaunt’s picture

richardgaunt commented
Issue summary: View changes
fionamorrison23’s picture

fionamorrison23 commented
Issue tags: +civictheme-release-1.11
fionamorrison23’s picture

fionamorrison23 commented
Version: 1.9.0 » 1.x-dev
fionamorrison23’s picture

fionamorrison23 commented
Issue tags: -civictheme-release-1.11
fionamorrison23’s picture

fionamorrison23 commented
Assigned: Unassigned » alan.cole
Status: Active » Needs review
fionamorrison23’s picture

fionamorrison23 commented
Assigned: alan.cole » richardgaunt
fionamorrison23’s picture

fionamorrison23 commented
Issue tags: +civictheme-release-1.12
richardgaunt’s picture

richardgaunt commented
Assigned: richardgaunt » danielgry
danielgry’s picture

danielgry commented
StatusFileSize
new ckeditor-settings1.png240.79 KB
new emailAndLinks.png864 KB
new themeSettings.png176 KB
new ckeditor-settings2.png166.68 KB
new urlsAndLinks2.png940.45 KB

Verified and tested on 1.x-dev

Testing Results:
1. With "components.link.email" added into the opt-outs, the plain email addresses correctly render as text and are not automatically converted into links
2. Verified manually added email links remain functional
3. URLs follow CKEditor settings as well
4. Removing the the opt-out makes email addresses auto link automatically on existing pages

Screenshots:
1. When "Convert URLs to links" is enabled, URLs and emails automatically turn to links.
image

image

2. When opting out of email link processing, and unchecking "Convert URLs to links", then URLs and emails turn to plain text unless specifically linked in CKEditor.
image

image

image

danielgry’s picture

danielgry commented
Assigned: danielgry » richardgaunt
Status: Needs review » Reviewed & tested by the community
fionamorrison23’s picture

fionamorrison23 commented
Version: 1.x-dev » 1.12.0
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

fionamorrison23’s picture

fionamorrison23 commented
Assigned: richardgaunt » Unassigned
richardgaunt’s picture

richardgaunt commented
Issue tags: +civictheme-release-1.13

This fix causes other issues.

Investigating how Drupal does converting of URLs emails are seen as URLs and are duly converted to links.

Users can only opt to have all links converted or no links converted - cannot choose at a granular level to convert emails but not other URLs.

Believe this was Antoine's issue to begin with.

Will revert the fix elsewhere.

fionamorrison23’s picture

fionamorrison23 commented
Issue tags: -civictheme-release-1.13

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.