Uninstalling a module deletes dashboards that have a block provided by that module
Instead of delete the dependent dashboard, the dashboard should show a broken block.
Instead of delete the dependent dashboard, the dashboard should remove the broken block (or section).
Fix the dependency calculation so it doesn't delete the dashboard.
None.
None.
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | module-uninstall.png | 61.65 KB | penyaskito |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
penyaskitoI'm not 100% sure if the proposed solution is the right UX.
The user has a confirmation form where it's informed that this would happen. They could always go to the dashboard, remove the offending blocks, and try to uninstall again.
Comment #3
catchI think this could use
ConfigEntityInterface::onDependencyRemoval()Comment #4
penyaskitoGood call, Probably we should do just as in
\Drupal\layout_builder\Entity\LayoutBuilderEntityViewDisplay::onDependencyRemovaland remove the block or section affected.Comment #6
penyaskitoThat MR is straight copypaste from LayoutBuilderEntityViewDisplay and works as expected. This needs tests tho.
Comment #7
penyaskitoComment #8
penyaskitoComment #9
plopescCode LGTM!
tested manually and the blocks from the uninstalled dependencies are removed, leaving the rest of the dashboard unaffected.
Marrking as RTBC.
Comment #10
plopescOut of the scope this issue but I wonder if would be worth to open a core issue where these methods would be moved to a trait for scenarios like this.
Comment #11
penyaskitoComment #12
penyaskitoNot opening a follow-up now for #10 in core, but tagging this for being able to find it later.
Comment #13
penyaskitoComment #15
penyaskitoThanks!