Problem/Motivation

The default view for menu administration with this module is configured to only show 10 items, with no pager. This means if you have more than 10 menus, you can't see them all on the admin page.

Steps to reproduce

Install this module. Add menus until you have more than 10. You won't be able to see the last ones.

Proposed resolution

Fix the default view for menus.

Remaining tasks

Create MR.

User interface changes

Will correctly show all menus after this change.

API changes

None.

Data model changes

None.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

zengenuity created an issue. See original summary.

zengenuity’s picture

Status: Active » Needs review
scott_euser’s picture

Thanks! Yeah that makes sense to have a default for future installs with no pagination. If someone uses a microsite builder type approach that generates tons of menus, they could change it for their edge cases.

Will do a manual test run when I can + check if we normally do update hooks for unchanged views or not or only consider future installs (bit new to helping co-maintain this one).

zengenuity’s picture

Adding a pager would also be a reasonable solution, which would account for the microsite sites. If the pager is set to 50 per page or so, then most people would never see it.

scott_euser’s picture

Good compromise solution yeah

zengenuity’s picture

Updated the MR to use a full pager with 50 items per page.

scott_euser’s picture

Status: Needs review » Fixed

Checked and we don't do update hooks for existing views. Added a tiny bit more test coverage to pager. Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.