Problem/Motivation

#type fieldgroup exists only to add a class and after #3512236: Move fieldgroup CSS to its own library a library.

The only place it's used in core is the installer site configure form. Field UI uses the fieldgroup class without using the #type (don't ask me why).

I think we can deprecate and remove this entirely.

Steps to reproduce

NA

Proposed resolution

Deprecate FieldGroup.php class

Remaining tasks

Review

User interface changes

NA

Introduced terminology

NA

API changes

NA

Data model changes

NA

Release notes snippet

FieldGroup.php is deprecated.

Issue fork drupal-3512254

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

catch created an issue. See original summary.

catch’s picture

sayan_k_dutta’s picture

Working on it.

sayan_k_dutta’s picture

Status: Active » Needs review

Made the changes. Removed the 'fieldgroup' from #type and added it as a class attribute.

smustgrave’s picture

Status: Needs review » Needs work

Title mentions deprecation but don’t see anything deprecated

sayan_k_dutta’s picture

Status: Needs work » Needs review
catch’s picture

Status: Needs review » Needs work

I think #6 has been misunderstood. The original change here was fine but incomplete, it should be restored and continue from that point - see note on MR about next steps.

Also see https://www.drupal.org/about/core/policies/core-change-policies/how-to-d...

sayan_k_dutta’s picture

Added the change record https://www.drupal.org/node/3515272

catch’s picture

Status: Needs work » Needs review

MR looks good to me now!

smustgrave’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Yes things look good now and match the description of the ticket. I went ahead and did it but also for good practice @sayan_k_dutta issue summary should be filled in please.

CR reads well too.

  • nod_ committed eeb7175a on 11.x
    Issue #3512254 by sayan_k_dutta, catch, smustgrave: Deprecate #type...
nod_’s picture

Status: Reviewed & tested by the community » Fixed

Committed eeb7175 and pushed to 11.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.