Problem/Motivation

Split from #2880237: [meta] Refactor system/base library.

Steps to reproduce

Start a clean install of standard, on the site information form in the installer, inspect HTML, and check that fieldgroup.module.css is added.

Can also disable CSS aggregation after install and ensure the file doesn't get loaded on a regular page (any page really because the element is just not used in runtime operation).

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3512236

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

catch created an issue. See original summary.

catch’s picture

Status: Active » Needs review
Issue tags: +Performance, +frontend performance
Related issues: +#2880237: [meta] Refactor system/base library

I'm not sure what testing instructions are here.

The field cardinality form adds the class without using the element type, but because the template and CSS are different in Claro it can't get broken by the change anyway.

The installer site configure form is the only code in core that actually uses the element, but this is also overridden by Claro so again I'm not sure installing with it actually validates the change either. Even the minimal profile uses Claro in the installer.

Because it's almost but not quite unused in core, and there appear to be only a couple of usages in contrib, I opened #3512254: Deprecate #type fieldgroup.

catch’s picture

Issue summary: View changes

OK I found a way to test.

Start a clean install of standard, on the site information form in the installer, inspect HTML, and check that fieldgroup.module.css is added.

Can also disable CSS aggregation after install and ensure the file doesn't get loaded on a regular page (any page really because the element is just not used in runtime operation).

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new103.86 KB

after

Seems to look the same as before to me.

  • nod_ committed fae1be90 on 11.x
    Issue #3512236 by catch, smustgrave: Move fieldgroup CSS to its own...
nod_’s picture

Status: Reviewed & tested by the community » Fixed

Committed fae1be9 and pushed to 11.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.