This is a strange, old helper function in our tests. It is not really a good method -- it makes it hard to tell what you're actually clicking, and it offers very little way to understand what, exactly, you're waiting for. It also has the ability to bypass the wait, which feels for all the world like a kludge that shouldn't be there.

We have better, more explicit assertion methods now, and don't need to rely on CSS selectors as much. Mink offers us a broad API for interacting with the page, and waiting for things. Its API is far more expressive, too. Let's switch to Mink's methods, and our own custom assertions/wait helpers, instead of relying on hard-to-grok stuff like clickWithWait().

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

phenaproxima created an issue. See original summary.

phenaproxima changed the visibility of the branch 3511417-remove-projectbrowseruitesttraitclickwithwait to hidden.

phenaproxima’s picture

Status: Active » Needs review
narendrar’s picture

Status: Needs review » Reviewed & tested by the community

All changes look good, tests are passing, moving it to RTBC.

tim.plunkett’s picture

Saving credit

tim.plunkett’s picture

Status: Reviewed & tested by the community » Fixed

Merged !778 🎉

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.