Problem/Motivation

Primary menu does not style correctly in the 'header bottom 1' region.

Steps to reproduce

1. Move the 'Primary Navigation' block to the 'Header bottom 1' region.
2. See that the menu does not style correctly.

Proposed resolution

Given the changes that will be implemented in the UI Kit as part of https://github.com/civictheme/uikit/issues/467, apply the necessary ct-navigation type to the primary navigation in any region.

Remaining tasks

1. In file: `/web/themes/contrib/civictheme/includes/menu.inc` add a new variable `type` to the $variables array. `primary` if `$menu_name === 'civictheme_primary_navigation'` or `secondary` if `$menu_name === 'civictheme_secondary_navigation'`.

2. In file: `/web/themes/contrib/civictheme/templates/block/block--menu-block--civictheme-primary-navigation.html.twig` add a new variable `type` to the `navigation.twig` file.

3. In file: `/web/themes/contrib/civictheme/templates/block/block--menu-block--civictheme-secondary-navigation.html.twig` add a new variable `type` to the `navigation.twig` file.

User interface changes

No changes to the UI.

API changes

No changes to the API.

Data model changes

No changes to the data model.

CommentFileSizeAuthor
#9 updating-block-stucture.png145.08 KBdanielgry
#9 original-header.png1.23 MBdanielgry
#9 primary-with-search-at-bottom.png1.28 MBdanielgry

Comments

alan.cole created an issue. See original summary.

fionamorrison23’s picture

fionamorrison23 commented
Issue summary: View changes
Issue tags: +civictheme-release-1.11
febdao’s picture

febdao commented

Hi Fiona,
The header has supported primary navigation in header bottom region now, please take a look into my PR https://github.com/civictheme/monorepo-drupal/pull/1356

Cheers,

fionamorrison23’s picture

fionamorrison23 commented
Version: 1.9.0 » 1.x-dev
fionamorrison23’s picture

fionamorrison23 commented
Issue tags: -civictheme-release-1.11 +civictheme-release-1.12
fionamorrison23’s picture

fionamorrison23 commented
Assigned: Unassigned » richardgaunt
Status: Active » Needs review

fionamorrison23 credited danielgry.

fionamorrison23’s picture

fionamorrison23 commented
Assigned: richardgaunt » danielgry
danielgry’s picture

danielgry commented
StatusFileSize
new primary-with-search-at-bottom.png1.28 MB
new original-header.png1.23 MB
new updating-block-stucture.png145.08 KB

Verified and tested on latest CivicTheme dev version

Testing Results:
1. Moving the Primary Navigation block to the Header bottom 1 now produces the expected view on the FE.
2. Verified Primary navigation displays the correct layout and retains the correct alignment as per the CivicTheme Figma design

Screenshots:
1. Original Header appearance
image

2. Moving primary nav block & search block into Header bottom 1
image

3. Viewing new header structure on frontend
image

danielgry’s picture

danielgry commented
Assigned: danielgry » richardgaunt
Status: Needs review » Reviewed & tested by the community
fionamorrison23’s picture

fionamorrison23 commented
Assigned: richardgaunt » Unassigned
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.