Problem/Motivation

#3508631: Load project data from a new QueryManager class that implements a centralized, static cache added the critical front-end infrastructure needed to display multiple project browsers on a single page.
In #3509184: Add a test of multiple project browsers on a page tests were written to validate this feature. Testing pagination for multiple instances on single page still needs to be done.

Steps to reproduce

Proposed resolution

Issue fork project_browser-3509674

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

narendrar created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Title: Add pagination test for multiple project browsers on a page » [PP-1] Add pagination test for multiple project browsers on a page
Status: Active » Postponed
Related issues: +#3509406: Add more projects to ProjectBrowserTestMock's fixture

Postponed on #3509406: Add more projects to ProjectBrowserTestMock's fixture.

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Title: [PP-1] Add pagination test for multiple project browsers on a page » Add pagination test for multiple project browsers on a page
Status: Postponed » Needs work

I think we can click 'Clear filters' as done in ProjectBrowserUiTest::testPaging() to test this.

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Title: Add pagination test for multiple project browsers on a page » [PP-1] Add pagination test for multiple project browsers on a page

This is blocked on #3509184: Add a test of multiple project browsers on a page

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Postponed
narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Title: [PP-1] Add pagination test for multiple project browsers on a page » Add pagination test for multiple project browsers on a page
Status: Postponed » Needs work

narendrar opened merge request !773

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Needs work » Needs review
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

I ❤️ this. It's essential coverage that we'll need in the wake of #3510506: Allow the project browser render element to take a customized pagination and predefined sort, and force max_selections to be global, which shows that pagination is the main thing that allows project browsers to be minified in the first place.

I made some relatively minor changes and factored out some helper methods, but the structure of the test remains in place. It's great work. Since we've got a shortage of reviewers at the moment, I'm calling this one RTBC and will go over it with Tim.

tim.plunkett made their first commit to this issue’s fork.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Fixed

This is so clean, love to see it.

Merged !773 🎉

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.