Problem/Motivation

drupal_core plugin is used to show modules provided by Drupal core. But it is also showing Standard profile in the list.

Steps to reproduce

Search Standard on /admin/modules/browse/drupal_core

Proposed resolution

Filter only modules for this plugin.

How to manually test

If you enable the "core modules" source and browse it, you should not see the current install profile (probably "Standard") amongst the results, and should not find it if you search for it. On 2.0.x HEAD, you will be able to see/find it.

Issue fork project_browser-3504781

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

narendrar created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented

Just to be clear, the "flaw" here is actually in core -- the current profile is always included in the output of ModuleExtensionList. See https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co... for where that happens.

Probably the correct solution here is for the plugin to inject the install_profile container parameter and, if it's set (it might not be, since profiles are uninstallable now), actively remove it from the found projects.

phenaproxima opened merge request !708

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Active » Needs review
Issue tags: +Needs tests

Could use review; I did a bit of clean-up in the code while I was at it. Will also need a test.

utkarsh_33 made their first commit to this issue’s fork.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Needs work
Issue tags: -Needs tests

That looks great! A couple of minor points.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review

Fixed PHPCS and switched back to the Testing profile, we don't need to use Standard for this.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Issue summary: View changes

chrisfromredfin made their first commit to this issue’s fork.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Needs review » Fixed

someone filed this a long time ago and closed with CNR - glad we found it again and fixed it

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.