When installing modules through the Project Browser (this may only happen with max_selections > 1, not sure) - during the install, three dots animate and move next to the install button in the bar at the bottom.
Pick some projects to install, then hit the install button.
Just remove the animated three dots - we have the spinner. (In a future issue we'll move the spinner down into the bar)
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | Issue-3504656-after.png | 25.56 KB | sandip |
| #6 | Issue-3504656-before.png | 25.54 KB | sandip |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #4
sandip commentedHi @omkar-pd,
Thank you for your work on this. However, there’s still one more thing left to address. While you have removed the .pb-elipsis class from the CSS, we also need to remove it where it was attached with the install button. i am working on this.
Comment #5
sandip commentedPlease review the changes.
Comment #6
sandip commentedAttaching before and after SS for better understanding.
Comment #7
utkarsh_33 commentedCan you also update the SS when max_selections > 1?
Comment #8
utkarsh_33 commentedManually tested this and the code changes looks good to me.The three dots don't appear in both cases.
Comment #9
sandip commentedHi @utkarsh_33, I am not getting any option in Project Browser UI to select multiple module to be installed (e.g. max_selections > 1). Can you guide me so i can take the SS and upload here too.
Comment #11
chrisfromredfinMoving back to NW.
You can set max_selections to one with drush or some other way to edit your config:
drush cset -y project_browser.admin_settings max_selections 1This completely removes the dancing dots, even when we need them, which is when max_selections is 1.
Alternatively, the spinner we use could be put up when max_selections = 1, and that would also be an OK alternative (perhaps even better, meaning consistent UI both ways).
Comment #12
utkarsh_33 commentedOnly showing the dancing dots when max_selections is 1.
Comment #13
sandip commentedHi @utkarsh_33, I noticed that when MAX_SELECTIONS > 1, an unnecessary empty class attribute is being added to the
<span>. To address this, I propose using the following approach:<span class:pb-ellipsis={MAX_SELECTIONS === 1}>{message}</span>This ensures that the class attribute is only included when MAX_SELECTIONS === 1, resulting in cleaner HTML output. Could you please share your thoughts on this solution?
Comment #14
utkarsh_33 commentedI completely agree with #13.I overlooked that.I have added what you suggested.
Comment #15
sandip commentedLGTM :)
Moving to RTBC++
Comment #17
chrisfromredfinThanks for the look, Sandip! Happy to have you here (especially if you have some Svelte chops!) :)
Comment #18
sandip commentedThank you @chrisfromredfin! Your appreciation means a lot to me. I’m still new to Svelte—I picked it up while working on this issue—but I’m excited to explore it further and apply it to future issues in Project Browser.
Thanks again 😄