Problem/Motivation

Reference: https://www.drupal.org/project/minifyhtml/issues/3504535
Currently, when using a module that allows to strip comments from your html, as for example provided in the minifyhtml module, we are breaking the output of ESI content.

Steps to reproduce

Enable the minifyhtml module and enable the comment stripping.
Enable the adv_varnish module, enable ESI, enable a block to use ESI and request the page from a url that passes varnish, ideally when not logged in.

You will notice that the block using ESI does not output anything.

Proposed resolution

Remove the <!-- esi comments from the module, or allow to disable these.
There is no direct use case to have these comments, as Varnish will replace the ESI element upon loading the page, it should not arrive at the end user.

Remaining tasks

I will create a patch to work around this, needs review.

Issue fork adv_varnish-3504543

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 4.x Comparechanges, plain diff MR !23
About issue forks

Comments

hoebekewim created an issue. See original summary.

hoebekewim’s picture

hoebekewim commented
Issue summary: View changes

hoebekewim opened merge request !23

hoebekewim’s picture

hoebekewim commented
Status: Needs work » Needs review

shumer made their first commit to this issue’s fork.

  • shumer committed 391f1f4a on 4.x authored by hoebekewim 
    Issue #3504543: Removal of ESI comment tag to allow comment strippers to...
shumer’s picture

shumer commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.