Closed (fixed)
Project:
Localization server
Version:
3.0.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
2 Feb 2025 at 11:55 UTC
Updated:
21 Sep 2026 at 13:25 UTC
Jump to comment: Most recent
l10n_packager_cron() still needs to be ported from Drupal 7.
Issue fork l10n_server-3503845
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
compare
Comments
Comment #2
fmb commentedThe commented part in l10n_packager_cron() creates queues that will later parse releases. This part did not exist in the Drupal 7 version. Besides, we already have a drush command (drush 10n_server:parse) which implements this and could be used directly in a crontab. Implementing this feature also in a queue would either lead to code duplication or require some refactoring. How relevant is this?
Comment #3
fmb commentedComment #4
gábor hojtsyAnswering #2: the Drupal 7 cron only calls
l10n_packager_check_updates()when the "Generate packages on every Drupal cron run" setting is on, and that part is already ported at this time. The commented queue code has no Drupal 7 counterpart, and the queue worker it would feed does nothing, so the change removes the commented block, the emptyl10n_server_packagerqueue worker and the packager release storage handler that only existed for it.What was missing is a test. Drupal 7 got
testCronPackaging()first: cron does not package by default, with the setting on and the interval set to every cron run it packages one file per run with the default file limit, the release only counts as checked once all its languages are done, and a partly packaged release is picked up again after the repackaging interval.PackagerCronTestis the port, on a shared kernel test base with the packaging test.LLM was used to find, diagnose explain and fix this issue. With human review.
Comment #7
gábor hojtsy