Closed (fixed)
Project:
Localization server
Version:
3.0.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
3 Feb 2023 at 16:25 UTC
Updated:
12 Sep 2025 at 13:24 UTC
Jump to comment: Most recent
Comments
Comment #2
fmb commentedComment #3
fmb commentedComment #4
fmb commentedIn the D9 version, a "release" can be either an l10n_server_release or an l10n_packager_release entity. In the D7 version, l10n_packager_release_set_branch applies to what would be an l10n_server_release entity, whereas l10n_packager_release_check would be l10n_packager_release. What is the point of the first call in this context anyway? How could this be solved, according to you?
Comment #6
fmb commentedComment #7
fmb commented@sanduhrs declared some arguments (force and all) which do not exist in the D7 version. What are we supposed to do?
I am not exactly sure what other two commands (create/queue) are for BTW.
Comment #9
fmb commentedApparently sanduhrs wanted to use the queue API in l10n_packager_cron(). I commented the code in the meantime until we make a decision on this point.
Comment #12
fmb commentedPostponing until migrations are a thing, so we can test on real data.
Comment #13
ptt-homme commentedComment #14
fmb commentedComment #15
fmb commentedComment #16
colorfieldDiscussed with @fmb during Barcamp Perpignan
Keep 1 to 1 port for now
Remove dead code:
- new options: force, all
- new (not implemented) drush commands: create, queue
As queue is not implemented yet, prevent to introduce extra complexity (release, unprocessed items)
D7 was not using it, so it should work https://git.drupalcode.org/project/l10n_server/-/blob/7.x-1.x/l10n_packa...
Make sure that it works like this
- Check database query with D7 one
- Set the source of truth
- Create test
Working on it
Comment #17
colorfieldComment #19
fmb commentedComment #20
fmb commentedThanks @colorfield!