Problem/Motivation

The original drush command is not yet ported: https://git.drupalcode.org/project/l10n_server/-/blob/7.x-1.x/l10n_packa...

Steps to reproduce

Check the initial repository for the logic and port it in the 3.x branch.

Proposed resolution

Identical logic port for now.

Remaining tasks

  • Porting logic
  • Tests

User interface changes

Should impact the Top downloads on the overview screen.

API changes

None

Data model changes

None

Comments

nicoloye created an issue. See original summary.

fmb’s picture

Parent issue: » #3274238: Port l10n_packager
fmb’s picture

Assigned: Unassigned » fmb
fmb’s picture

In the D9 version, a "release" can be either an l10n_server_release or an l10n_packager_release entity. In the D7 version, l10n_packager_release_set_branch applies to what would be an l10n_server_release entity, whereas l10n_packager_release_check would be l10n_packager_release. What is the point of the first call in this context anyway? How could this be solved, according to you?

  • FMB committed 6e8e1277 on 3.0.x
    Issue #3338985 by FMB: Finalize l10n_packager drush command
    
fmb’s picture

Status: Active » Needs review
fmb’s picture

@sanduhrs declared some arguments (force and all) which do not exist in the D7 version. What are we supposed to do?

I am not exactly sure what other two commands (create/queue) are for BTW.

  • FMB committed 329d197c on 3.0.x
    Issue #3338985 by FMB: Finalize l10n_packager drush command (cron)
    
fmb’s picture

Apparently sanduhrs wanted to use the queue API in l10n_packager_cron(). I commented the code in the meantime until we make a decision on this point.

  • FMB committed 602182cb on 3.0.x
    Issue #3338985 by FMB: Finalize l10n_packager drush command (cron)
    

  • FMB committed e7f53620 on 3.0.x
    Issue #3338985 by FMB, nicoloye: Finalize l10n_packager drush command (...
fmb’s picture

Status: Needs review » Postponed

Postponing until migrations are a thing, so we can test on real data.

ptt-homme’s picture

Status: Postponed » Needs work
fmb’s picture

fmb’s picture

Assigned: fmb » Unassigned
Status: Needs work » Needs review
colorfield’s picture

Discussed with @fmb during Barcamp Perpignan

Keep 1 to 1 port for now

Remove dead code:
- new options: force, all
- new (not implemented) drush commands: create, queue

As queue is not implemented yet, prevent to introduce extra complexity (release, unprocessed items)
D7 was not using it, so it should work https://git.drupalcode.org/project/l10n_server/-/blob/7.x-1.x/l10n_packa...

Make sure that it works like this
- Check database query with D7 one
- Set the source of truth
- Create test

Working on it

colorfield’s picture

Issue tags: +BarCampPerpignan2025

  • colorfield committed 6de0ede4 on 3.0.x
    Issue #3338985 by colorfield: remove dead code, use attributes
    
fmb’s picture

Status: Needs review » Fixed
fmb’s picture

Thanks @colorfield!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.