Problem/Motivation

I believe when we merged #3484474: Change UI for the install queue to match bulk operations, we introduced a UI bug which brings the install process "up top" during the install phase. With max_selections set to 1, we shouldn't have a trace of "add to cart" functionality - so this should not happen in that case.

Steps to reproduce

Set configuration to only allow 1 project at a time to be installed. (in DDEV, with Drush, I use `ddev drush cset -y project_browser.admin_settings max_selections 1`)

Proposed resolution

Hide the "bar" altogether when max_selections is == 1.

Issue fork project_browser-3502854

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chrisfromredfin created an issue. See original summary.

narendrar made their first commit to this issue’s fork.

narendrar opened merge request !702

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Active » Needs review
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

No objections to this code. I haven't manually tested but it looks solid to me. Pretty sure @chrisfromredfin will do a better job of kicking the tires than I will!

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the review. Manually testing showed this is good!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.