Closed (fixed)
Project:
Drupal core
Version:
11.x-dev
Component:
migration system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
28 Jan 2025 at 10:42 UTC
Updated:
22 Oct 2025 at 16:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
quietone commentedComment #3
quietone commentedComment #4
quietone commentedComment #5
quietone commentedComment #6
benjifisherUpdated from discussion on the Migrate video call today. benjifisher, heddn, mikelutz and quietone were present. #3518542: [meeting] Migrate Meeting 2025-04-24 2100Z
Comment #8
quietone commentedStarting over. Will deprecating FieldPluginBase be sufficient, similar to DrupalSqlBase for the source plugins?
Comment #10
heddnRe #8: let's try that. It gives things the greatest visibility.
Comment #11
heddnIts green.
Comment #12
quietone commentedREmoved some '@group legacy' because of the deprecation is in .deprecation-ignore.txt. That keeps this consistent with the way the source plugins are deprecated.
This looks fine to me.
Comment #13
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #14
quietone commentedI added
@phpstan-ignore classConstant.deprecatedClassto two test files to fix reported errors from the use of#[CoversClass( )]with a deprecated class.Comment #15
smustgrave commentedUsing CR as a guide https://www.drupal.org/node/3533566 matches the MR which appear to be good deprecations.
Comment #16
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #18
quietone commentedTo fix the rebase errors I generated the phpstan baseline and MigrateFieldPluginManagerTest.php.
Comment #19
smustgrave commentedSeems like a good rebase.
Comment #21
catchCommitted/pushed to 11.x, thanks!
Comment #24
catch