Problem/Motivation

Track the steps needed to deprecate extension Migrate Drupal. See Remove a core module and move it to a contributed project of the deprecation policy. Since Migrate Drupal is not moving to contrib, those steps are not included.

The removal of extension Migrate Drupal was approved in #3371229: [Policy] Migrate Drupal and Migrate Drupal UI after Drupal 7 EOL.

Remaining tasks

  1. Move integrations implemented by other modules to the extension.
    Create child issues or child meta issues, as needed, to address the following points. Not all points will apply to all extensions.
  2. Do a thorough search of core for any remaining references to the extension. If references are found, outside of the extension, then create issues to remove the references.

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Issue summary: View changes

This was discussed at the migrate meeting, #3313883: [meeting] Migrate Meeting 2022-10-13 2100Z. benjifisher, mikelutz, dinarcon and myself were present. We agreed to make a move on this and start testing how to move everything to Migrate Drupal. We also agreed to do the work by module. And it may be a good idea to start with content_translation because it is most likely to expose challenges.

I've created this issue using the Issue Summary template for deprecating extensions and adding the specific items for moving migrations from a core module to Migrate Drupal.

quietone’s picture

quietone commented

The duplicate issue proposed "Create contributed module to host the migrations (to receive the code when its removed from core).". At the meeting the consensus was that the preferred option was to move everything in to Migrate Drupal. Creating sub-modules of that is an option but one that no one spoke in favor of.

quietone’s picture

quietone commented
Issue summary: View changes
markdorison’s picture

markdorison
he/him
commented
Issue summary: View changes
quietone’s picture

quietone commented
Issue summary: View changes

Fix formatting in IS.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

catch’s picture

catch
he/him
Primary language English
commented

I feel like there's another issue to discuss this, but putting here for now.

We need to decide when to do this, IMO it should be something like this:

It makes sense to support the Drupal 7 migrations in core until Drupal 7 is EOL, but for as short a time as possible after that date. That way supported Drupal 7 sites can migrate to a supported version of core, but unsupported Drupal 7 sites will eventually need to rely on the contrib module.

Therefore, if the Drupal 7 EOL date falls within the support cycle for Drupal 10, we should deprecate migrate_drupal in Drupal 10 for removal in Drupal 11.

joachim’s picture

joachim commented

Migrate Drupal isn't just for migrating from old sites. It's really useful for doing data migrations *within* a site. I've used it for things like migrating box entities to paragraphs, for instance.

catch’s picture

catch
he/him
Primary language English
commented

@joachim are you using migrate_drupal to do in-site migrations or just migrate? This issue is only about migrate_drupal. If so, which bits of migrate_drupal are you using? If there's stuff that's generically useful, then we ought to be moving that to migrate anyway I think - migrate_drupal is only supposed to be for d6 and d7.

joachim’s picture

joachim commented

I use \Drupal\migrate_drupal\Plugin\migrate\source\ContentEntity a lot!

catch’s picture

catch
he/him
Primary language English
commented

OK yeah there is that and \Drupal\migrate_drupal\Plugin\migrate\source\d8\Config. That seems worth migrating to the migrate module since it's version-agnostic - or even if we moved them to contrib they shouldn't be in a d6/d7 migrate module that's going to eventually drop support.

quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Issue tags: +Needs release manager review

There's been some discussion among the release managers about other options for how to remove Migrate Drupal and Migrate Drupal UI. There was no decision, just knocking around ideas.

So, I am tagging this to a full discussion can take place.

catch’s picture

catch
he/him
Primary language English
commented

I think we need to discuss this in #3371229: [Policy] Migrate Drupal and Migrate Drupal UI after Drupal 7 EOL and leave this issue for figuring out mechanics, leaving the tag on but will comment over there.

quietone’s picture

quietone commented
Issue summary: View changes
Status: Active » Postponed (maintainer needs more info)

Postponing on the policy issue

quietone’s picture

quietone commented
Status: Postponed (maintainer needs more info) » Postponed
quietone’s picture

quietone commented
Issue summary: View changes
Status: Postponed » Active
Issue tags: -Needs release manager review
Related issues: +#3371229: [Policy] Migrate Drupal and Migrate Drupal UI after Drupal 7 EOL
quietone’s picture

quietone commented
Parent issue: » #3466088: [meta] Deprecate dependencies, libraries, modules, and themes that will be removed from Drupal 12 core
dcam’s picture

dcam commented

I use \Drupal\migrate_drupal\Plugin\migrate\source\ContentEntity a lot!

Thanks for bringing this up, @joachim. I came here to ask that it be preserved too. It's fantastic for doing data transformations within a site. And I'd look forward to not having to enable all of migrate_drupal just to have access to it.

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented

@joachim, @dcam:

Good news! We plan to keep the content_entity source plugin. In fact, #3498915: Move content_entity source plugin to migrate module is currently RTBC.

dcam’s picture

dcam commented

@benjifisher Thanks for the update and link!

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented

I think we should also re-implement the d8_config source plugin (see Comment #12 here). I added the child issue #3506605: Move the d8_config source plugin to the migrate module.

quietone’s picture

quietone commented
Issue summary: View changes
Status: Active » Postponed
quietone’s picture

quietone commented
Issue summary: View changes
Status: Postponed » Active

Oops, postponed the wrong issue

andypost’s picture

andypost
he/him
Primary language Russian
commented

It looks blocked on

- #2922451: [policy no patch] Make it possible to mark plugins as deprecated
- #3039240: Create a way to declare a plugin as deprecated

catch’s picture

catch
he/him
Primary language English
commented

@andypost it's not blocked on either of those issues.

We can deprecate the entire migrate_drupal module for removal in 12.x and then remove it then, that will notify any site that has the module enabled.

Next step is #3506605: Move the d8_config source plugin to the migrate module still.

quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Related issues: +#3522602: [meta] Tasks to remove Migrate Drupal module
quietone’s picture

quietone commented
Title: Tasks to deprecate Migrate Drupal » [meta] Tasks to deprecate Migrate Drupal
quietone’s picture

quietone commented
Issue summary: View changes

Migrate Drupal is used in tests in the migrate module. There are also usages in comments in the migrate module.

quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented

With the plugins deprecated that leaves searching for other usages in core. Using git grep -l migrate_drupal I found a usage in core/lib/Drupal/Core/Test/TestDiscovery.php that needs to be investigated. There are also usages in the migrate module but they are in comments or tests and can be removed when the code is removed. At least that is my initial finding.

quietone’s picture

quietone commented

Ah, the usage in core/lib/Drupal/Core/Test/TestDiscovery.php is no longer relevant. It is checking for the namespace ''migrate_drupal\Tests\Table" which was removed from core in That namespace was removed in 2015, in #2568203: Remove migrate-db.sh in favor of core tools.

So, it looks like the next step is to deprecate the module itself.

quietone’s picture

quietone commented

All the child issues are Fixed.

The one remaining task is to triage the migration system and close issues such as feature requests.

quietone’s picture

quietone commented

Because the migration component contains both Migrate Drupal specific and Migrate API issues it will take some time to close and/or update the correct issues. I think that will happen over time and discussions can be made in the #migration channel when questions arise. Therefore, I updated credit and closing this as fixed.

Thanks everyone! It has been a grand ride :-)

quietone’s picture

quietone commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone’s picture

quietone commented
Status: Closed (fixed) » Active

There are text references to migrate drupal as well as tests using migrate drupal in the migrate module

Re-opening because, at least this step is not complete.

I've added a child for the tests, #3573895: Fix test integrations using migrate_drupal . And will make one for the help topics now.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Fixed

Last one merged, closing again

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

quietone’s picture

quietone commented

This is now truly fixed, the final issue #3573895: Fix test integrations using migrate_drupal was committed to main and 11.x. It fixed some tests integrations I missed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.