Problem/Motivation

After checking a warning in #3502643: PHP warning - Undefined array key "name" in DrupalDotOrgJsonApi.php, I thought about this property and we might not need it at all.
We currently have as author:
- Core modules: hardcoded to "Drupal Core"
- Recipes: empty
- Contrib modules: name of the user that created the module

The person that created a module might or might not be a maintainer of the module, and they might even cancel their account and the module would still exists.

So I'm not sure that author is a useful property right now.

Proposed resolution

Discuss if the above make sense and if it does, clean up code everywhere.

If we want to think about maintainers, that should be a separate follow-up from this issue in my opinion. This should be about clean up a property that is not really useful.

Issue fork project_browser-3502734

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fjgarlin created an issue. See original summary.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Related issues: +#3494824: Cleanup of Project object contract/constructor

This is related to #3494824: Cleanup of Project object contract/constructor

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Active » Postponed
Related issues: +#3498121: Add information about authors and maintainers in project details page

This runs directly counter to #3498121: Add information about authors and maintainers in project details page. Which one do we want to do?

poker10’s picture

poker10 commented

If author != one of the maintainers on d.o., then this is probably not dependent. Otherwise -1 to this. Commented on the related issue.

fjgarlin’s picture

fjgarlin commented

I commented on the other issue, I still think that this should be done as author (person that created the node) is not the same as maintainers.

As mentioned in the issue description

The person that created a module might or might not be a maintainer of the module, and they might even cancel their account and the module would still exists.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Title: Remove author from Projects » Remove author from Project
Category: Feature request » Task
Status: Postponed » Active
Issue tags: +API clean-up

Thanks for clearing that up, @fjgarlin. I think it makes sense, then, to remove the $authors property from Project now, along with its Svelte representation, and add a new $maintainers property in the other issue when the d.o side is ready.

fjgarlin opened merge request !714

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Active » Closed (duplicate)

Closing as a duplicate of #3494824: Cleanup of Project object contract/constructor, let's just do this in there.

fjgarlin’s picture

fjgarlin commented

Ouch! I had the MR ready, was just waiting for the pipeline to finish.

fjgarlin’s picture

fjgarlin commented

But just saw that you already transferred the commit!! Great!