Replace install/select button with a Drupal-standard drop button

So you are not blocked, my plan is for the backend to send the links as part of the encoded Project objects, like so:

{
  // ...other properties of the project...
  "tasks": [
    {
      "text": "Something",
      "url": "https://my.site/some/path"
    },
    {
      // ...another link...
    }
  ]
}

Pretty simple stuff! But you should be able to rely on that. I'll update here if anything changes.

I think this is a great start. Let's block it on #3322601: Make ModuleActivator expose a Configure follow-up task for modules which have one, which will actually deliver a Configure link for modules, and give us something to really integrate with.

Blocker is in!

This seems like a great start and is straightforward. I think we might want to add some test coverage for the keyboard functionality, though. There might be preexisting test coverage in core you could use?

I think this is great. There are some things that could use tightening up and there might be a little missing test coverage, but this broadly seems like it covers all our bases. Amazing work.

I gave this a manual test, and found two problems, one of which is commit-blocking.

First, if you install some modules (that you don't already have), once the installation completes, the badge is rerendered as a dropdown that looks utterly broken:

If you refresh the page, it looks correct. But clicking "Installed" just knocks you back to the top of page without explanation; it feels like a bug. This, we can fix in a follow-up.

I tried using the actual links in the dropbutton and they all worked as expected.

Re #23, Tested manually and it is working on my end. One problem which I see is that Uninstall should take you to current page and not /admin/modules/uninstall after a module is installed and you try to uninstall it without refreshing the page.

Gave this another manual test. What I found is that installing a module that's already present (a core module, in this case) does immediately create the correct drop button actions. Clicking "Installed" no longer skips me around the page, so that's good! The actions themselves work as expected -- I'm not sure I understand what's being described in #24, it behaves as I would expect it to. But if it's a pre-existing problem in 2.0.x, let's file a follow-up to deal with that.

The only major commit-blocking problem I still see is that...I can't close the dropbutton once I open it. Clicking the toggle doesn't close it. Clicking outside the drop button doesn't close it. We need to fix these and cover it in the test. Additionally, I am able to open more than one drop button at a time, since they aren't closing reliably. We also need to test that only one can be open at a time.

I added some additional test coverage here, and I'm happy with the code here, I think. This is ready for final review and manual testing!

No follow-up is needed here; everything I found in #21 is fixed.

Re-reviewed, re-tested, all looks good. Awesome work @utkarsh_33!

I love where this is headed, but I have two UI concerns.

(1) the "Installed" first line of the dropbutton is non-functional. I think that breaks a pattern we have in Drupal where the first link of a dropbutton is a primary action. I think it's worthwhile to move the "Installed ✔️" to a div ABOVE the dropbutton so that each thing of the drop button is clickable.

(2) This I think solves my other problem, which is that right now on Recipes, they don't have any follow-up tasks, so there's just an "Installed" dropbutton with a carat that you can click and unclick and it flips and unflips, but functionally does nothing. In this way, things without tasks simply don't have buttons and only show the installed.

Quick mockup I fiddled with the Inspector:

..bear in mind, I would love it if "Installed" stayed where it is today, and the dropbutton showed up underneath that, even if it means cards get taller for now where needed.

And one small code nit - I would love it if we called it Dropbutton.svelte instead of DropDownButton.svelte, just to keep in line with Drupal language. We are really trying to mimic/re-invent a common Drupal pattern here in Svelte, so let's intimate that with the language.

Thanks for the review! Back to @utkarsh_33 to implement the desired changes. Those don't sound too tricky.

Regarding #35: I tested both ways and I think I prefer the "Installed" badge being on top, and the drop button being below it. I think this makes more sense semantically, and it also means that very long-titled actions in the drop button won't be disruptive to the design.

I'm trying hard to make sure this lands today, so I think I'm gonna restore RTBC and then review it intensively with @chrisfromredfin.

Let's see if I can assign credit with my new issue-maintainer powers...

cool, and getting cooler!

I may follow a design FU but it shouldn't block this.