Overview

Title says it all mostly: let's also reorder the entries in both *.routing.ymland /openapi.yml to be alphabetically sorted.

(@traviscarden initially did that over at #3486203: Integrate saving sections with the backend: (de)normalize Pattern config entities using the client-side data model.)

Proposed resolution

Do it. Test it to ensure it does not regress.

Refactor the most obvious inconsistencies away with perfect confidence thanks to the new guardrails the aforementioned test coverage added:

User interface changes

None.

Issue fork experience_builder-3499703

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

wim leers created an issue. See original summary.

wim leers credited tedbow.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

@tedbow also raised this earlier today :)

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +clean-up

nexusnovaz made their first commit to this issue’s fork.

nexusnovaz’s picture

nexusnovaz commented

Are we going to sort .routing by the route name, or the path?

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#3484678: Simplify ComponentSourceInterface::getClientSideInfo(), introduce ClientSideRepresentation value object, and leverage it

#6: you can choose :)

FYI: one rename for consistency is already happening in #3484678: Simplify ComponentSourceInterface::getClientSideInfo(), introduce ClientSideRepresentation value object, and leverage it 🥳

anjali rathod’s picture

anjali rathod
Primary language English
Location India
commented
Assigned: Unassigned » anjali rathod

anjali rathod opened merge request !616

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Thanks for pushing this forward! 😊

anjali rathod closed merge request !616

anjali rathod opened merge request !626

anjali rathod closed merge request !626

anjali rathod reopened merge request !626

anjali rathod’s picture

anjali rathod
Primary language English
Location India
commented
Status: Active » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: anjali rathod » wim leers
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

#3499550: Support server-side massaging and validating of ComponentInputsForm values conflicted heavily with this. Rather than continuing to postpone this, I bit the bullet and redid parts of what @anjali rathod did.

Now doing a proper review!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Make all XB HTTP API routes consistently prefixed » Make all XB HTTP API routes consistently prefixed, ensure they all have OpenAPI specs, and tests to keep it so
Assigned: wim leers » Unassigned
Status: Needs review » Reviewed & tested by the community
Issue tags: +openapi

Conflicted with #3505774: Merge ApiPendingChangesController and ApiPublishAllController, clarify connection, but thanks to the unit test added here, fixing that was a breeze 😄

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed
nagwani’s picture

nagwani commented
Issue tags: +sprint
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Related issues: +#3471064: OpenApi validation is not enforced because openapi.yml uses `patternProperties` which is not supported by our dependencies

It would good to get #3471064: OpenApi validation is not enforced because openapi.yml uses `patternProperties` which is not supported by our dependencies fixed next. We still have 3 large parts of openapi.yml spec that is getting ignored, and we will likely add more until we get this fixed(the problem got worse last month)

nagwani’s picture

nagwani commented
Issue tags: -sprint

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.