Drupal 11 compatibility

CommentFileSizeAuthor
#2 drupal-11-compatibility-3499641-2.patch1.31 KBintrafusion

Issue fork loqate-3499641

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

intrafusion created an issue. See original summary.

intrafusion’s picture

intrafusion
Primary language English
Location Edinburgh, UK
commented
Status: Active » Needs review
StatusFileSize
new drupal-11-compatibility-3499641-2.patch1.31 KB

intrafusion changed the visibility of the branch 3.x to hidden.

intrafusion opened merge request !5

baikho’s picture

baikho commented
Status: Needs review » Needs work
intrafusion’s picture

intrafusion
Primary language English
Location Edinburgh, UK
commented
Status: Needs work » Needs review

@baikho I don't understand why this BC layer is needed? Certainly not for Drupal 11 compatibility

baikho’s picture

baikho commented

#6

@baikho I don't understand why this BC layer is needed? Certainly not for Drupal 11 compatibility

It's needed because we are not dropping compatibility with the older Core versions of D9 and D10

intrafusion’s picture

intrafusion
Primary language English
Location Edinburgh, UK
commented

It's needed because we are not dropping compatibility with the older Core versions of D9 and D10

But that's not a D11 compatibility issue, that's a separate maintenance issue

baikho’s picture

baikho commented
Status: Needs review » Needs work

#8

But that's not a D11 compatibility issue, that's a separate maintenance issue

Please look at the Change Record https://www.drupal.org/node/3375748#bc, the change is introduced in Core 10.2.x, so any older Drupal will break with this change if the BC layer isn't in place.

intrafusion’s picture

intrafusion
Primary language English
Location Edinburgh, UK
commented

But this specific change to make this module compatible with Drupal 11 has nothing to do with backwards compatibility.

That is a separate maintenance issue as anyone currently running this module on anything older will already be experiencing that, I created the issue and patch so we could run Drupal 11 in production, if you want this backwards compatibility over a year after I created this patch then fine, but I will not be spending any additional time/effort to do so

zerdiox’s picture

zerdiox commented

The change to the annotation will break BC for older versions, you are pushing the module forward to D11 and introducing a BC issue while doing so. The added BC-layer @baikho requested prevents this break.

baikho’s picture

baikho commented

#10

But this specific change to make this module compatible with Drupal 11 has nothing to do with backwards compatibility.

That is a separate maintenance issue as anyone currently running this module on anything older will already be experiencing that, I created the issue and patch so we could run Drupal 11 in production, if you want this backwards compatibility over a year after I created this patch then fine, but I will not be spending any additional time/effort to do so

You’re wrong. I don’t want to go in circles, this change cannot be accepted without the BC layer.

siliconmeadow’s picture

siliconmeadow commented

Think of the BC layer as a "it just works" feature so that people don't have to be concerned about the issue you're so keen on resolving - that it will work without the user/administrator of the site having to specify the right version because they're not able to take their site to the very forefront of Drupal. Just make it seamless for them please.

Yours sincerely,

Someone who has to occasionally maintain some older sites

bwilliams1992 made their first commit to this issue’s fork.

  • baikho committed be32570a on 3.x authored by intrafusion 
    feat: #3499641 Drupal 11 compatibility

By: intrafusion
By: baikho
By:...
baikho’s picture

baikho commented
Status: Needs work » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

baikho opened merge request !7

  • baikho committed ba85d69e on 3.x 
    fix: #3499641 missing field type categories YAML file

By: baikho

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.