Problem/Motivation

The Nightwatch test which involves navigating through the PB UI with the keyboard is failing. Since 99% of our tests are functional JS test under PHPUnit anyway, let's convert it to that.

Steps to reproduce

Proposed resolution

The failing test will be removed in #3496236: Fix tests, convert the test to a functional JS test under PHPUnit.

Comments

ressa created an issue. See original summary.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Active » Postponed
Related issues: +#3501481: Rewrite Nightwatch tests as Playwright

We currently have Nightwatch tests up and running again. The keyboard-based navigation support in Nightwatch is superior to what we can do in Mink / FunctionalJavaScript tests with PHPUnit.

I think this will probably eventually be Closed (won't fix) as we'll likely convert the Nightwatch tests to Playwright in #3501481: Rewrite Nightwatch tests as Playwright.

ressa’s picture

ressa
he/him
commented

Great to hear that new and superior solutions are being implemented, like Playwright here and Cypress elsewhere. The Drop is Always Moving!

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Postponed » Closed (won't fix)

This has turned out to be extremely hard, maybe impossible, in PHPUnit because Mink doesn't seem to have very clear or good keyboard support. Screw it. If we've got Nightwatch running, we can stick with that; hopefully we can go to Playwright in the future and that will make things easier on us.