Problem/Motivation

The Svelte code is littered with the word "queue", which refers to the list of projects the user has chosen to install/activate. "Queue" is a very confusing word to use for this and should be changed to something else. Maybe batch or installList or something would be better.

CommentFileSizeAuthor
#11 Screenshot from 2025-02-05 12-21-56.png265.5 KButtam

Issue fork project_browser-3497909

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

phenaproxima created an issue. See original summary.

utkarsh_33 made their first commit to this issue’s fork.

utkarsh_33 opened merge request !706

utkarsh_33’s picture

utkarsh_33 commented
Status: Active » Needs review
omkar-pd’s picture

omkar-pd commented
Status: Needs review » Reviewed & tested by the community

Changes look good.

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented

The single instance which I found (not in svelte code) is 

  /**
   * Tests that adding projects to queue is plugin specific.
   */
  public function testPluginSpecificQueue(): void {

I think, this can also be addressed in this issue.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Reviewed & tested by the community » Needs work

I agree with @narendrar, here's just remove that now to clear up confusion for future-us.

utkarsh_33’s picture

utkarsh_33 commented
Status: Needs work » Needs review
uttam’s picture

uttam commented
Assigned: Unassigned » uttam
narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Assigned: uttam » Unassigned
Status: Needs review » Reviewed & tested by the community

Changes looks good to me.

uttam’s picture

uttam commented
StatusFileSize
new Screenshot from 2025-02-05 12-21-56.png265.5 KB

I installed the development version 2.0.x-dev and attempted to apply this merge request. However, upon installing the project_browser module, I encountered a WSOD error.

After investigating, I found a related issue that is currently postponed: Issue #3501254.

I also reviewed the source code for the changes made in the MR, and it looks good to me.

chrisfromredfin made their first commit to this issue’s fork.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Reviewed & tested by the community » Postponed

<borat>very nice</borat>

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Postponed » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.