Problem/Motivation

Convert plugin discovery to attributes instead of doctrine comments.

Proposed resolution

Convert plugin discovery to attributes instead of doctrine comments.

Remaining tasks

MR

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork dashboard-3496108

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

penyaskito created an issue. See original summary.

penyaskito opened merge request !50

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Active » Needs review
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs review » Postponed

Sadly this requires 11.1 for entity types.
So postponing for now.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Hi,

Is this a duplicate of #3543079: Convert phpdoc doctrine plugin annotation to modern attributes ?

Edit: or the opposite depending on creation date. I may have posted the comment in the wrong issue, sorry.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Postponed » Active

You are totally right.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Active » Closed (duplicate)
Related issues: +#3543079: Convert phpdoc doctrine plugin annotation to modern attributes

I took a different approach using rector instead of manual conversion, so we can just ignore this MR.
I'll start from scratch on the other one.

penyaskito closed merge request !50