Deprecated: Drupal\metatag\MetatagToken::replace(): Implicitly marking parameter $bubbleable_metadata as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/modules/contrib/metatag/src/MetatagToken.php on line 60

Deprecated: Drupal\metatag\MetatagManager::getDefaultMetatags(): Implicitly marking parameter $entity as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/modules/contrib/metatag/src/MetatagManager.php on line 470

Deprecated: Drupal\metatag\MetatagManager::generateRawElements(): Implicitly marking parameter $cache as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/modules/contrib/metatag/src/MetatagManager.php on line 594

Deprecated: Drupal\metatag\MetatagManagerInterface::generateRawElements(): Implicitly marking parameter $cache as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/modules/contrib/metatag/src/MetatagManagerInterface.php on line 128
CommentFileSizeAuthor
#7 metatag-3495867-deprecation-php-84.patch5.2 KBmrdalesmith
#5 deprecation-php-3495867.patch2.17 KBdeepali sardana

Issue fork metatag-3495867

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

heyyo created an issue. See original summary.

deepali sardana’s picture

deepali sardana commented
Assigned: Unassigned »
deepali sardana’s picture

deepali sardana commented
Assigned: » Unassigned
deepali sardana’s picture

deepali sardana commented
Assigned: Unassigned »
deepali sardana’s picture

deepali sardana commented
Assigned: » Unassigned
Status: Active » Needs review
StatusFileSize
new deprecation-php-3495867.patch2.17 KB

I was trying to create mr but that was giving error please accept the patch and review it

mrdalesmith’s picture

mrdalesmith commented
Status: Needs review » Needs work

Patch doesn't cleanly apply to the current 2.1.0 release or dev version.

Fork used in branch looks pretty messed up: this may need a clean start.

mrdalesmith’s picture

mrdalesmith commented
Status: Needs work » Needs review
StatusFileSize
new metatag-3495867-deprecation-php-84.patch5.2 KB

Attached patch should apply cleanly now.

acbramley changed the visibility of the branch 8.x-1.x to hidden.

acbramley changed the visibility of the branch 3495867-deprecation-php-8.4 to hidden.

acbramley opened merge request !173

acbramley’s picture

acbramley commented

Applied #7 to an MR.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #3486197: Plan for Metatag 2.2.0
Related issues: +#3486218: Plan for Metatag 2.1.1
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Closed (duplicate)
Parent issue: #3486197: Plan for Metatag 2.2.0 » #3490807: Fix PHP 8.4 deprecations
Related issues: -#3486218: Plan for Metatag 2.1.1

This is a duplicate of #3490807: Fix PHP 8.4 deprecations.

acbramley closed merge request !173

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Closed (duplicate) » Active
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Fixed

Giving folks here credit for working on this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.