Problem/Motivation

While working on #3489054: Make the "add to cart" threshold configurable, it is observed that Drupal.t() is not used correctly in some parts of the code. This can lead to issues with translations and localization.
Refer to the discussion: https://git.drupalcode.org/project/project_browser/-/merge_requests/644#...

Steps to reproduce

  • Identify the parts of the codebase where Drupal.t() is implemented incorrectly.
  • Verify the functionality and localization behavior.

Proposed resolution

Audit the entire project for instances where Drupal.t() is used. Fix the incorrect implementations to ensure proper usage throughout the codebase.

Issue fork project_browser-3495211

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

narendrar created an issue. See original summary.

arunsahijpal’s picture

arunsahijpal commented
Assigned: Unassigned » arunsahijpal

Working on it.

arunsahijpal opened merge request !660

arunsahijpal’s picture

arunsahijpal commented
Assigned: arunsahijpal » Unassigned
Status: Active » Needs review

Hi @narendrar,
I've parsed through whole codebase and corrected Drupal.t() where required, please check.

utkarsh_33’s picture

utkarsh_33 commented
Status: Needs review » Reviewed & tested by the community

I have verified that all the Drupal.t() usages are now correctly used and changes look good to me, so marking this RTBC.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Reviewed & tested by the community » Needs work

Mostly looks right to me, but I think you missed a spot :)

arunsahijpal’s picture

arunsahijpal commented
Status: Needs work » Needs review

Hi @phenaproxima,
I've made the changes pls look.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me!

chrisfromredfin made their first commit to this issue’s fork.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Reviewed & tested by the community » Fixed

Hard to manually test visually-hidden things, but we got there!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.