Problem/Motivation

I use Laravel Valet as local development environment and I want to use Ngrok to test PDF generation locally. Valet even has a command, valet share, to easily set up Ngrok. It looks like in code there's a check if the user is using DDEV before the ngrok_url setting is considered, so I can't use it.

Proposed resolution

Use the ngrok_url setting if it's present, regardless of the local development environment the user is using. This setting should be set in local.settings.php to make sure it doesn't end up in production.

Issue fork page_to_pdf-3492689

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dieterholvoet created an issue. See original summary.

dieterholvoet opened merge request !16

dieterholvoet’s picture

dieterholvoet commented
Status: Active » Needs review

scott_euser made their first commit to this issue’s fork.

scott_euser’s picture

scott_euser commented
Status: Needs review » Fixed

The str_contains closing bracket was in the wrong spot, but otherwise LGTM thanks!

dieterholvoet’s picture

dieterholvoet commented
Status: Needs review » Fixed
scott_euser’s picture

scott_euser commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.