Problem/Motivation

When you set up accessible-menu on a menu, and then delete said menu, the config for accessible-menu doesn't go away.

Steps to reproduce

1. Create new menu
2. Set up accessible-menu on it
3. Delete new menu
4. Export config. Accessible-menu config exports.

Proposed resolution

On menu deletion, clear out that menu's accessible-menu config.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

nickdjm created an issue. See original summary.

atul_ghate’s picture

Assigned: Unassigned » atul_ghate

atul_ghate’s picture

Assigned: atul_ghate » Unassigned
Status: Active » Needs review
divyansh.gupta’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new85.06 KB
new73.9 KB

I reproduced this issue and applied the MR which fixed the problem of accessible-menu configurations even after deleting the menu.
Before:
before
After:
after
Thus moving it to RTBC+!

nickdjm’s picture

Version: 1.0.0-beta6 » 1.x-dev
Status: Reviewed & tested by the community » Fixed

Thanks for the MR, I appreciate it!

I brought the branch up-to-date and gave it a test. Looks like it works as intended. Merged.

I'll get a new beta release out shortly since there's not 2 bug fixes that need to go out.

divyansh.gupta’s picture

Hi @nickdjm,
Thank you for the swift action in merging the MR. The issue seems to be resolved and the state has been updated correctly as well. However, I noticed that contributor credits were not added.
I kindly request you to review and address this, as acknowledging contributions with a credit plays a vital role in motivating us to continue making meaningful contributions.
Thanks and regards
Divyansh

nickdjm’s picture

Sorry, I thought I checked your names off. Clearly I did not. Corrected!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.