Problem/Motivation

It is not possible to save the image widget crop settings.

Saving configuration causes the following error:

Drupal\Core\Config\ImmutableConfigException: Can not set values on immutable configuration image_widget_crop.settings:settings.library_url

Steps to reproduce

1. Install image_widget_crop
2. Go to /admin/config/media/crop-widget
3. Save configuration

Proposed resolution

Use $this->config to get the configuration object, instead of getting it from config.factory.

CommentFileSizeAuthor
#11 image_widget_crop_fix.patch781 bytesnatefollmer
#10 image_widget_crop.patch846 bytesanschinsan

Issue fork image_widget_crop-3491004

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

omarlopesino created an issue. See original summary.

omarlopesino opened merge request !37

omarlopesino’s picture

omarlopesino
he/him
commented
Status: Active » Needs review

I've created a MR that fixes the problem. Please review, thanks!

omarlopesino changed the visibility of the branch 8.x-2.x to hidden.

mably’s picture

mably commented
Status: Needs review » Reviewed & tested by the community

Hit by the same problem, can confirm that the contributed patch fixes the problem, thanks!

opi’s picture

opi
Primary language French
commented

Works well with D11.1.1 + IWC dev-2.x 2f10025 , thanks.

joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented
Title: Can't save image widget crop settings in Drupal 11 » Can't save image widget crop settings (ImmutableConfigException)
Issue summary: View changes

Closed #3496678: ImmutableConfigException as a duplicate of this issue. Ideally this should be fixed in 3.0.x-dev first but also backported to 8.x-2.x. @sweetchuck contributed to the closed issue and should also be credited here.

webmestre’s picture

webmestre commented

Hello,
the 3.0.x-dev version also produces:

Drupal\Core\Config\ImmutableConfigException: Can not set values on immutable configuration image_widget_crop.settings:settings.library_url. Use \Drupal\Core\Config\ConfigFactoryInterface::getEditable() to retrieve a mutable configuration object in Drupal\Core\Config\ImmutableConfig->set() (line 27 of core/lib/Drupal/Core/Config/ImmutableConfig.php).

I'm using the 11.1.2 Drupal version

joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented
Priority: Normal » Major

Increasing priority to major since it is impossible to save module config currently.

anschinsan’s picture

anschinsan commented
StatusFileSize
new image_widget_crop.patch846 bytes

Fix it by getting settings editable

natefollmer’s picture

natefollmer commented
StatusFileSize
new image_widget_crop_fix.patch781 bytes

Path issue with previous patch that caused patching to fail. I've fixed the paths. This one should work. I can now save settings after applying this patch.

anup.singh made their first commit to this issue’s fork.

anup.singh’s picture

anup.singh commented

Latest patch are working and it seems to be correct approach, So update the MR with same.

joelpittet made their first commit to this issue’s fork.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Just ran into this, thanks for putting this together, hopefully this can be merged soon.

solideogloria’s picture

solideogloria commented

+1 please merge.

jesss’s picture

jesss commented

The MR works for me. I hope this gets merged soon -- this module is unusable without it.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Issue tags: +Needs followup

I'm going to merge this to get people unblocked, even though the bug itself is due to a preexisting, incorrect pattern -- you are never supposed to inject a config object into a form (or any class) as a dependency.

The correct pattern would be for the form to override the getEditableConfigNames() method, and use $this->config() internally to load config. Core will guarantee that it gets editable versions of anything listed in getEditableConfigNames().

Merging this on the good-faith assumption that some kindly person will open a follow-up issue in which to do that cleanup.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Reviewed & tested by the community » Fixed

The merge train has now left the station! Should be committed shortly when all tests pass.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Thanks a bunch @phenaproxima created that follow-up #3545190: Refactor form to use $this->config() instead of injecting config

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.