I installed the 4.1.1 release in a Drupal 11 site and tried to visit the settings.

ArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct(), 1 passed in /var/www/html/web/modules/contrib/site_audit/src/Form/SiteAuditConfigForm.php on line 31 and exactly 2 expected in Drupal\Core\Form\ConfigFormBase->__construct() (line 43 of /var/www/html/web/core/lib/Drupal/Core/Form/ConfigFormBase.php).

CommentFileSizeAuthor
#7 site_audit-fix_for_ArgumentCountError-3490817-7.patch1.65 KBnoah
#5 image.png157.26 KBarunsahijpal
#4 site_audit-fix_for_ArgumentCountError-3490817-4.patch3.46 KBpriti197

Issue fork site_audit-3490817

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

keiserjb created an issue. See original summary.

keiserjb’s picture

keiserjb commented

Add TypedConfigManagerInterface to SiteAuditConfigForm constructor

- Updated constructor to inject TypedConfigManagerInterface as required.
- Fixed compatibility with ConfigFormBase parent class.
- Updated `create()` method to include `config.typed` service.

keiserjb’s picture

keiserjb commented
priti197’s picture

priti197 commented
StatusFileSize
new site_audit-fix_for_ArgumentCountError-3490817-4.patch3.46 KB

Created a patch to fix the issue.

arunsahijpal’s picture

arunsahijpal commented
StatusFileSize
new image.png157.26 KB

Hey @keiserjb,
I have installed this module and there is no errors in the settings.
Here is the ss for reference. Please add to steps to reproduce if it exists in your site.

keiserjb’s picture

keiserjb commented

Good to know, perhaps it was me. I shall try again.

noah’s picture

noah commented
StatusFileSize
new site_audit-fix_for_ArgumentCountError-3490817-7.patch1.65 KB

I was getting this error after upgrading Drupal from 10.4.2 to 11.1.2. The patch at 4 works great to resolve the issue, but I had to make a few minor tweaks to get it to apply:

  1. The patch has an extra level of prefix in the file paths (they start with “/site_audit/”, so the patch has to be applied with -p2 rather than -p1 and can't be applied via Composer): I removed the extra level.
  2. The patch line endings are CRLF instead of LF (so I suspect it applies in Windows, but it doesn't elsewhere): I switched to LF.
  3. The patch file encoding shows up as UTF-16 Little Endian rather than UTF-8: I switched to UTF-8.

So the code in the patch attached here is identical, only some meta stuff in the patch file is different.

kalash-j’s picture

kalash-j commented
Assigned: Unassigned » kalash-j

froboy opened merge request !17

froboy’s picture

froboy
he/him
Primary language English
Location Chicago, IL
commented
Assigned: kalash-j » Unassigned
Status: Active » Reviewed & tested by the community

I've tested the patch in git with composer patches against site_audit 4.1.1. It applies cleanly and resolves the issue.

I'm going to call this RTBC. I've opened the MR so it's easily mergable.

@kalash-j it does not look like you are a maintainer of the module, so you should not have assigned this issue to yourself. I've unassigned it.

  • froboy committed 1bb74623 on 4.x 
    [#3490817] Add TypedConfigManagerInterface to SiteAuditConfigForm...
froboy’s picture

froboy
he/him
Primary language English
Location Chicago, IL
commented

Thanks everyone. Tested and merged to 4.x. Releasing shortly.

froboy’s picture

froboy
he/him
Primary language English
Location Chicago, IL
commented
Version: 4.1.1 » 4.1.2
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.