Problem/Motivation

With pager:

: [items[0].title] Integer value found, but a string is required/n[items[1].title] Integer value found, but a string is required/n[items[2].title] Integer value found, but a string is required/n[items[3].title] Integer value found, but a string is required in <em class="placeholder">Drupal\Core\Theme\Component\ComponentValidator-&gt;validateProps()</em>

Issue fork ui_patterns-3490733

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

grimreaper created an issue. See original summary.

grimreaper opened merge request !280

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » pdureau
Status: Active » Needs review
just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented

the check seems a bit weak.
what cases we have?
integers, strings, markup, render array ?!, bool, floats, arrays...? who knows
i guess we wan't to keep the normalizing efficient and simple while
protecting against bad data injected, whatever it comes
from.
do we add other cases?

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented

more generally, do we need a better normalizing for string props? in that case the title of a link maybe normalized the same way string props are/would be normalized ?

pdureau’s picture

pdureau commented
more generally, do we need a better normalizing for string props? in that case the title of a link maybe normalized the same way string props are/would be normalized ?

Unfortunately, we cant' apply StringPropType normalization to links item titles, because we discovered than links item titles can be renderables.

  • grimreaper committed e7baca91 on 2.0.x 
    Issue #3490733 by grimreaper: LinkPropType normalization...again
pdureau’s picture

pdureau commented
Assigned: pdureau » Unassigned
Status: Needs review » Fixed
just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Related issues: +#3492154: Error for some user menu links, +#3491238: [2.0.0-beta6] normalization of slots triggers some unwanted filtering

according to comments from #3491238: [2.0.0-beta6] normalization of slots triggers some unwanted filtering,
there are new work to do on normalization.
i have opened a new separate issue https://www.drupal.org/project/ui_patterns/issues/3492211

pdureau’s picture

pdureau commented
Title: LinkPropType normalization...again » [2.0.0-beta6] LinkPropType normalization...again
pdureau’s picture

pdureau commented
Status: Fixed » Closed (fixed)