Problem/Motivation
when a component contains some form elements for example, and that exact component is injected, with twig, into the slot of another components, then the html is being filtered and all form elements disappeared.
Issue fork ui_patterns-3491238
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
just_like_good_vibesComment #4
just_like_good_vibessorry a last error to correct
Comment #5
just_like_good_vibesolé !
Comment #6
smustgrave commentedJust want to chime in that this was found while converting component() to include(). In ui_suite_uswds we use nested include() in the page.html.twig and without this fix it's not possible. SO thanks for the quick fix!!
Comment #7
pdureau commentedWith your change, do we lose this logic?
I don't see the
array_valuesequivalent in:Comment #8
just_like_good_vibesHello,
array_map is always loosing keys, so yes the logic is kept.
i will add a test for that
Comment #9
just_like_good_vibesok, back for review
Comment #10
just_like_good_vibesi added another check just for you :)
Comment #11
pdureau commentedI will merge today
Comment #12
just_like_good_vibesthanks Pierre
Comment #14
pdureau commentedComment #15
grimreaperHi,
Thanks for the additional fixes, ok for me.
Comment #18
grimreaperHi,
I think there is still a remaining case not handled.
With UI Suite Bootstrap 5.1.x, UI Patterns 2.0.x and Drupal Commerce, on user/1/address-book, I have:
So I tried in app/modules/contrib/ui_patterns/src/Plugin/UiPatterns/PropType/LinksPropType.php::normalizeTitle() to add:
Then another case when $title is a renderable array.
Comment #19
just_like_good_vibeshello,
this belongs to another ticket, because it is linkproptype normalization and not slot
Comment #20
steveoriolWith UI Suite DaisyUI, UI Patterns 2.0.x
and Drupal Commerce (on user/1/address-book)
or Webform (on user/1/submissions) ...
Same error as grimreaper
Comment #21
just_like_good_vibessee #3492211: [2.0.0-beta6] Normalization...suite, we stay closed this issue and work in a new clean one.
Comment #22
pdureau commentedComment #23
pdureau commented