Novice issue reserved for folks starting their contribution journey. If you have gained enough experience, please consider other contribution opportunities. Thanks.

Problem/Motivation

Historically, Drupal.org has included license files when packaging modules and themes. If someone sets up a mirror of the Git repository of this module, there will not be license information. We want to explicitly distribute a license with the module's repository.

Steps to reproduce

Review the module's code repository at https://git.drupalcode.org/project/auto_increment_alter and verify that:

  • No LICENSE.txt file exists in the root of the repository.
  • No license information is present in the composer.json file.

Proposed resolution

  • Add the same LICENSE.txt file used by Drupal core.
  • Add license information to the module's composer.json file.

Remaining tasks

  1. Copy the LICENSE.txt file used by Drupal core into the root of this module's repository. It found at https://git.drupalcode.org/project/drupal/-/blob/11.x/core/LICENSE.txt
  2. Update the module's composer.json file to include license information.
  3. Commit the changes and create a merge request (MR).

The composer.json file should look something like this:

{
    "name": "drupal/auto_increment_alter",
    "description": "Alter AUTO_INCREMENT value of database tables.",
    "license": "GPL-2.0-or-later",
    "type": "drupal-module",

Resources

You might want to reference the following resources:

First contributions

Similar issues

Issue fork auto_increment_alter-3490571

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dinarcon created an issue. See original summary.

Anonymous’s picture

Anonymous (not verified) commented

akulsaxena made their first commit to this issue’s fork.

akulsaxena opened merge request !8

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review

Hi
I have added the LICENSE.txt file as requested
The PHPCS and cspell pipelines are failing but an issue has already been created for the same.
Please review and merge

jvbrian made their first commit to this issue’s fork.

Anonymous’s picture

Anonymous (not verified) commented

Hi @jvbrian
I already generated the MR and made the necessary changes.
The issue was already in Needs Review state.
All you have done is add two spaces extra in 2 different files, which is actually not required.
Please ensure if the issue you pick is already assigned to someone or is in needs review state and the work is complete, you should not work on it until it moves back to needs work state and is unassigned.

dinarcon’s picture

dinarcon commented

Thanks for working on this @akulsaxena

Hi @jvbrian It is indeed strange to add the spaces to those files when such change is not necessary. The current status of the issue is Needs Review. Can you verify that the necessary changes, as instructed in the issue summary, have been implemented? And if so, can you add a comment indicating you have reviewed the issue and change the issue status to Reviewed & tested by the community (RTBC)?

I have rebased the MR after #3492309: Fix cspell and phpcs issues The pipelines are already passing.

Anonymous’s picture

Anonymous (not verified) commented

@jvbrian
Will you be reviewing this? The licence file has been added and the required code for the same is already present in the composer.json file. Let me know if you find any other issue otherwise this can be set to RTBC and then merged.

dhruv.mittal’s picture

dhruv.mittal commented
Status: Needs review » Reviewed & tested by the community

Hey, I reviewed the MR and the changes look good enough
The license file was added and composer.json has the required license information
Pipelines are all green.
Moving it to RTBC
Thanks

  • dinarcon committed 57da51d5 on 1.0.x authored by akulsaxena 
    Issue #3490571 by akulsaxena, dinarcon, dhruv.mittal: Add license file
dinarcon’s picture

dinarcon commented
Status: Reviewed & tested by the community » Fixed

Thanks for working on this @akulsaxena and for your review @dhruv.mittal

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.