Problem/Motivation

Alignment issue between the input and filter.

Steps to reproduce

Step1 : Install Drupal
Step2 : Set Olivero as the administration theme.
Step3 : Home > Administration > Content
You will be able to see the issue.
issue

Proposed resolution

You need toupdate margin-block: 0;
proposed-resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#26 content-filter-fixed.png54.81 KBdanrod
#25 thecomments.png32.7 KBdanrod
#25 comment_form.png41.94 KBdanrod
#22 content_filter_cta.png15.08 KBanjaliprasannan
#22 comment_filter_cta.png12.9 KBanjaliprasannan
#22 article comment.png33.73 KBanjaliprasannan
#19 cta-alignment.png115.47 KBpinesso
#16 3490443_after.png131.43 KBdivyansh.gupta
#16 3490443_before.png131.41 KBdivyansh.gupta
#13 Screenshot 2024-12-03 at 4.23.39 PM.png105.4 KBsaurav-drupal-dev
#13 Screenshot 2024-12-03 at 4.11.37 PM.png85.7 KBsaurav-drupal-dev
proposed-resolution.png345.26 KBdjsagar
Issue.png27.44 KBdjsagar

Issue fork drupal-3490443

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

djsagar created an issue. See original summary.

djsagar’s picture

djsagar commented
Priority: Major » Minor
djsagar’s picture

djsagar commented
Issue tags: +Novice
cilefen’s picture

cilefen commented
Component: CSS » Olivero theme
quietone’s picture

quietone commented
Version: 11.1.x-dev » 11.x-dev

Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.

jvbrian made their first commit to this issue’s fork.

jvbrian opened merge request !10404

ahsannazir made their first commit to this issue’s fork.

ahsannazir opened merge request !10432

ahsannazir’s picture

ahsannazir commented
Status: Active » Needs review

saurav-drupal-dev made their first commit to this issue’s fork.

saurav-drupal-dev opened merge request !10438

saurav-drupal-dev’s picture

saurav-drupal-dev commented
StatusFileSize
new Screenshot 2024-12-03 at 4.11.37 PM.png85.7 KB
new Screenshot 2024-12-03 at 4.23.39 PM.png105.4 KB

the issue was still reproducible for me created MR for it.

Before Fix
before

After Fix
after

divyansh.gupta changed the visibility of the branch 3490443-action-btn-margin to hidden.

divyansh.gupta changed the visibility of the branch 3490443-input-and-filter to hidden.

divyansh.gupta’s picture

divyansh.gupta commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3490443_before.png131.41 KB
new 3490443_after.png131.43 KB

I reviewed MR!10438 and the changes seem to be working fine.
Also, the pipeline is passing without any errors and warnings.
Hiding the other MR's and moving the issue to RTBC+.
Attaching before and after fix screenshots for reference.

Before:
Before

After:
After

ahsannazir’s picture

ahsannazir commented

The MR #10438 seems similar to existing MR #10432. I have updated MR#10432 with latest changes from 11.x.
It is advised to not create duplicate MRs

ahsannazir changed the visibility of the branch 3490443-action-btn-margin to active.

pinesso’s picture

pinesso commented
StatusFileSize
new cta-alignment.png115.47 KB

I confirmed testing over the Merge request !10432 the issue has been fixed.

CTA Alignment

Thank you!

mandymeng’s picture

mandymeng commented
Issue tags: +DrupalNYCContributionDay

I confirmed 'Filter' button alignment on my local system.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Reviewed & tested by the community » Needs work

Which branch should be reviewed?

how does the public comment form look after this change (under an article for example)?

anjaliprasannan’s picture

anjaliprasannan commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new article comment.png33.73 KB
new comment_filter_cta.png12.9 KB
new content_filter_cta.png15.08 KB

Nod_ MR !10432 should be reviewed.

I have tested in the branch and it is working fine.
Screenshots:
Only local images are allowed.
coment

For article comment the comment looks like below
article

As the issue is fixed moving to RTBC and MR can be merged.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Reviewed & tested by the community » Needs work

Can you show the comment form with the texarea and the submit button before/after, not only the posted comment ? thanks!

anjaliprasannan’s picture

anjaliprasannan commented

@nod_ Please find the screenshot

Only local images are allowed.

danrod’s picture

danrod
Location Ottawa
commented
StatusFileSize
new comment_form.png41.94 KB
new thecomments.png32.7 KB

Hi @nod_ it looks ok me :

Screenshot of the comments

Screenshot of the comment form

danrod’s picture

danrod
Location Ottawa
commented
StatusFileSize
new content-filter-fixed.png54.81 KB

Tested Content and looks ok too:

Screenshot of content filter

danrod’s picture

danrod
Location Ottawa
commented
Status: Needs work » Needs review
anjaliprasannan’s picture

anjaliprasannan commented
Status: Needs review » Reviewed & tested by the community

nod_ closed merge request !10438

nod_ closed merge request !10432

  • nod_ committed c239b2eb on 11.x 
    Issue #3490443 by saurav-drupal-dev, ahsannazir, nod_, jvbrian, djsagar...
nod_’s picture

nod_
Primary language French
Location Lille
commented
Title: Input and filter alignment issue on the comments tab. » Input and filter alignment issue on the comments tab
Status: Reviewed & tested by the community » Fixed

Committed c239b2e and pushed to 11.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.