Problem/Motivation

Images on detail page of project browser do not render due to path issue.

Steps to reproduce

Go to any detail page, eg /admin/modules/browse/drupalorg_jsonapi/drupal-token-token and see that slider has placeholder image only.

Proposed resolution

Replace assets with files in project_images of response.

Issue fork project_browser-3489827

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

narendrar created an issue. See original summary.

fjgarlin’s picture

fjgarlin commented
Assigned: Unassigned » fjgarlin

I'll take care of this.

fjgarlin opened merge request !630

fjgarlin’s picture

fjgarlin commented
Assigned: fjgarlin » Unassigned
Status: Active » Needs review
narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Needs review » Reviewed & tested by the community

Changes looks good to me. Just to add that if changes are not reflecting change the order of the enable source plugins or add disabled one.

drumm’s picture

drumm
he/him
Location NY, US
commented

I was concerned about this hard-coding paths on Drupal.org, but this looks relatively safe. It will become a no-op as Drupal.org aligns to its modern infrastructure. It could use a bit more of a code comment explaining that.

chrisfromredfin made their first commit to this issue’s fork.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Reviewed & tested by the community » Fixed

two +1's from DA, so let it rip!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.