Problem/Motivation

civictheme_get_field_value does not support Text (formatted) field type

Steps to reproduce

1. Create a Text (formatted) [machine_name: `text`] field type
2. Attempt to retrieve the value with `civictheme_get_field_value`
3. Return value is null as field is not supported

Proposed resolution

Text field type should return the same as `long_text` and `text_with_summary`

Remaining tasks

1. Update civictheme_get_field_value to support this field type.

API changes

Data model changes

Issue fork civictheme-3488811

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

richardgaunt created an issue. See original summary.

shubham_pareek_19’s picture

shubham_pareek_19 commented
Assigned: Unassigned » shubham_pareek_19

working on it.

shubham_pareek_19 opened merge request !15

shubham_pareek_19’s picture

shubham_pareek_19 commented
Assigned: shubham_pareek_19 » Unassigned
Status: Active » Needs work
shubham_pareek_19’s picture

shubham_pareek_19 commented
Status: Needs work » Needs review
joshua1234511’s picture

joshua1234511
Primary language English
Location Goa
commented

@shubham_pareek_19 thank you for the MR, but we don't have a field type as 'text_formatted' its suppose to be 'text'

Added the MR on the repo https://github.com/civictheme/monorepo-drupal/pull/1323

Details on where to submit MR can be found at https://www.drupal.org/project/civictheme - "Where to submit issues and PRs"

  • 6a663bc6 committed on 1.x 
    Issue #3488811 by joshua1234511, richardgaunt, shubham_pareek_19: Extend...

  • 349e1210 committed on 1.x 
    Issue #3488811 by joshua1234511, richardgaunt, fionamorrison23: Wrong...
fionamorrison23’s picture

fionamorrison23 commented
Version: 1.8.2 » 1.x-dev
fionamorrison23’s picture

fionamorrison23 commented
Issue tags: +civictheme-release-1.11

fionamorrison23 credited danielgry.

fionamorrison23’s picture

fionamorrison23 commented
fionamorrison23’s picture

fionamorrison23 commented
Issue tags: -civictheme-release-1.11 +civictheme-release-1.12
shubham_pareek_19’s picture

shubham_pareek_19 commented

As fix is already committed on 1.x can we move this issue to Fixed!!

fionamorrison23’s picture

fionamorrison23 commented

Hi @shubham_pareek_19, this work still needs QA, so it's not ready to move to Fixed yet. As soon as it passes QA we're able to move it to fixed. Thanks.

fionamorrison23’s picture

fionamorrison23 commented
Assigned: Unassigned » richardgaunt
fionamorrison23’s picture

fionamorrison23 commented
Assigned: richardgaunt » Unassigned
Status: Needs review » Reviewed & tested by the community
fionamorrison23’s picture

fionamorrison23 commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

fionamorrison23’s picture

fionamorrison23 commented
Version: 1.x-dev » 1.12.0
fionamorrison23’s picture

fionamorrison23 commented
Assigned: Unassigned » danielgry
Status: Fixed » Needs review
danielgry’s picture

danielgry commented
Assigned: danielgry » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.