Problem/Motivation

We are standardizing on prop names across components.

Proposed resolution

Update these variables:

breadcrumb_block -> items_block
breadcrumbs_items -> items
breadcrumbs_classes -> classes
CommentFileSizeAuthor
#4 Update-Breadcrumb-Props-3488774.patch1.49 KBananya.k

Issue fork prototype-3488774

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jldust created an issue. See original summary.

jldust’s picture

jldust commented
Issue summary: View changes
ananya.k’s picture

ananya.k commented
Assigned: Unassigned » ananya.k
ananya.k’s picture

ananya.k commented
Assigned: ananya.k » Unassigned
Status: Active » Needs review
StatusFileSize
new Update-Breadcrumb-Props-3488774.patch1.49 KB

I have made changes. Please refer to attached patch.

b-ry made their first commit to this issue’s fork.

b-ry opened merge request !158

  • jldust committed 50849589 on 5.x authored by b-ry 
    Issue #3488774 by b-ry, ananya.k, jldust: Component: Update Breadcrumb...
jldust’s picture

jldust commented
Status: Needs review » Fixed

Looks great! This has been merged in and will be included in the next tagged release.

jldust’s picture

jldust commented
Status: Fixed » Closed (fixed)