Fix defgroup open and close that were separated during Hook conversion

I am starting to work on this issue during Dictus Drupal Dev Day.

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

I performed Novice Triage on this issue. I am leaving the Novice tag on this issue because there is a clearly defined task for resolution. The issue summary could use an update as well.

There were some test failures in the merge request, but I think those are false positives.

Novice issue reserved for the Mentored Contribution during the DrupalCon Atlanta 2025 contribution day. After 2025.03.27, this issue returns to being open to all. Thanks

I am looking at this issue at DrupalCon Atlanta. I am working with @heilop

Reviewed the patch and confirmed that the def groups were opened and closed appropriately and the orphaned opens and closes were removed.

Automated testing is failing, I created new merge request to rerun tests.

As @jazzsequence mentioned, the MR request shows that the defgroup are looking good now.

After the new MR has been opened to re-run the tests, we can now confirm that the test passed. Also, the tests were run locally and passed as well.

It looks like the issue summary has been updated. When updating the issue summary, we want to remember to remove the tag as well.

It would be nice to get another person to do a code review.

I verified that the functions grouped by @defgroup and @addtogroup are correctly placed and no missing opening and closing doxygen exist.

Just took a look to the MR at https://git.drupalcode.org/project/drupal/-/merge_requests/11653 and it looks good to me

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Rebased.

I reviewed the change and there is nice work here to make sure the 'end group' is in the correct place. Unfortunately, this found a bug in the sniff, Drupal.Commenting.InlineComment.DocBlock. For that, there is a few more steps here. They are in my comment on the MR and I have added that to the issue summary.

Each of the steps are suitable for the 'Novice' tag, so I am leaving the tag.

I also was to pass on that it is not necessary to open a NR to run tests. Tests can be re-run using the GitLab UI.

Sorry, should have set it to NR before instead of back to RTBC.

I followed the instructions to revert my earlier changes and add the ignore directive.

The Coder module follow-up has been created at #3517312: "@} End" doc comments should be allowed at the end of classes.

I figure that the Core queue follow-up should wait until this one is committed, but I can make it now if someone wants.

Do we need to add a @todo with the issue url for the coder issue above the ignore?

I removed the Needs followup tag since @dcam created the issue.

I don't think an @todo is needed, a followup, tagged 'Coding standards', is sufficient.

Tried my best to review this one. Based on the files mentioned in the summary believe they have been fixed, If I'm wrong I apologize now.

Committed/pushed to 11.x and cherry-picked to 11.2.x ,thanks!

Tagging needs follow-up for the core follow-up issue to remove the phpcs:ignore, which will need to be postponed on the coder issue.

Follow-up created at #3529873: [PP-1] Remove phpcs:ignore in TaxonomyHooks.