Problem/Motivation

#3310908: Make the 'detail page' a modal window instead of a separate "page" in app is introducing a dialog modal for the details element. Alongside an aria-haspopup="dialog" attribute is being added to the button on the module cards for opening the detail dialog modal. the View commands button doesn't have that aria attribute yet.

Steps to reproduce

Proposed resolution

Add the aria-haspopup="dialog" attribute

Issue fork project_browser-3488141

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rkoller created an issue. See original summary.

rkoller opened merge request !620

rkoller’s picture

rkoller
he/him
Primary language German
Location Nürnberg, Germany
commented
Status: Active » Needs review
rkoller’s picture

rkoller
he/him
Primary language German
Location Nürnberg, Germany
commented
Assigned: rkoller » Unassigned
chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Issue tags: +core-mvp, +stable blocker

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Needs review » Fixed

Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.