Problem/Motivation

There are a few labels using title case, but Drupal style is to use sentence case for headings and page titles (basically anything except module and theme names).

Also the source descriptions are inconsistent, two start with a verb and one doesn't, and one ends with a full stop and two don't.

Proposed resolution

For consistency, we should update the labels to use sentence case and tweak the source descriptions.

Issue fork project_browser-3488078

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pameeela created an issue. See original summary.

pameeela opened merge request !619

pameeela’s picture

pameeela commented
Status: Active » Needs review

Proposed some tweaks in an MR.

pameeela’s picture

pameeela commented
Related issues: +#3484802: Update extensions page title to be more clear

The tab case may be because of the AU "Update Extensions" tab, I also created an issue for that. #3484802: Update extensions page title to be more clear

ankitv18’s picture

ankitv18 commented
Status: Needs review » Needs work

Hi @pameeela,
As per the file changes ~~ could you please update the functional javascript tests.
see: https://git.drupalcode.org/issue/project_browser-3488078/-/jobs/3390931

Moving into NW

shalini_jha’s picture

shalini_jha commented
Assigned: Unassigned » shalini_jha

checking for test failures.

shalini_jha’s picture

shalini_jha commented
Assigned: shalini_jha » Unassigned
Status: Needs work » Needs review

I have checked the pipeline failure, replicated it locally, and fixed the issue. The pipeline is now green. Moving this to "Needs Review." Kindly review.

pameeela’s picture

pameeela commented

Thanks @shalini_jha!

ankitv18’s picture

ankitv18 commented
Status: Needs review » Reviewed & tested by the community

Looks good ~~ marking this one RTBC

chrisfromredfin made their first commit to this issue’s fork.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented

Thanks all! Rebased in the face of getting the modal in today, which actually shrank the footprint of this MR.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Reviewed & tested by the community » Fixed

woops, somehow missed the fixed part.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.