Problem/Motivation

Since the key is part of the URL we are passing, GitGuardian and other security minded people may have issue with this when checked into a repo. There could be a config form that captures it which would allow people to use the settings file and/or dotenv to keep it a secret. Then the GoogleSheets class can just append said key to the end of the URL and keep everyone happy. Thoughts?

Issue fork migrate_google_sheets-3487362

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 3487362-api-config Comparechanges, plain diff MR !7
  • 2.x Comparecompare
About issue forks

Comments

markie created an issue. See original summary.

markie opened merge request !7

karlshea made their first commit to this issue’s fork.

karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented
Status: Active » Reviewed & tested by the community

Good idea!

Added DI and checked to make sure the key doesn't already exist in the URL.

karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented
Version: 2.1.0 » 2.x-dev

  • karlshea committed e290f2c5 on 2.x authored by markie 
    Issue #3487362 by karlshea, markie: API Key being committed to the repo
karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.