Problem/Motivation

Expanding some field types in the add index form result in nothing getting expanded.

Steps to reproduce

Try expanding language for example.

In this screenshot you can see Language is expanded with the minus shown, yet there are no nested fields.

Proposed resolution

Update the check for whether to expand or not to depend on whether there are actual results possible.

Remaining tasks

MR

CommentFileSizeAuthor
expand-language.png42.12 KBscott_euser

Issue fork search_api-3486765

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

scott_euser created an issue. See original summary.

drunken monkey made their first commit to this issue’s fork.

drunken monkey’s picture

Component: General code » User interface
Status: Active » Needs review

Created an MR with an attempted fix. I think that should cover almost all cases. Please give it a try!

scott_euser’s picture

Status: Needs review » Reviewed & tested by the community

Works for me, Language no longer has an expand button, everything else that used to have an Expand button continues to have one. Thanks!

  • drunken monkey committed 525738f7 on 8.x-1.x
    Issue #3486765 by drunken monkey: Fixed superfluous “Expand” buttons in...
drunken monkey’s picture

Status: Reviewed & tested by the community » Fixed

Great to hear, thanks a lot for testing!
Merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.