Problem/Motivation

Search API SOLR IndexAddSolrDocumentFieldsForm::buildForm() overrides a lot for a minor change to the datasource loading only. In #3484811: Improve the Search API admin UI for adding/editing fields current plan is to break apart buildForm() to make it easier to extend.

Steps to reproduce

Look at the buildForm() method

Proposed resolution

Extend only the new method

Remaining tasks

MR

User interface changes

Allow inheriting the updated add index UI

API changes

N/A

Data model changes

N/A

Issue fork search_api_solr-3486761

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

scott_euser created an issue. See original summary.

scott_euser opened merge request !50

scott_euser’s picture

scott_euser commented
Status: Active » Needs review

Probably better as 'Postponed' but setting to needs review as it would be good to get this reviewed and ready to go prior to #3484811: Improve the Search API admin UI for adding/editing fields merge.

scott_euser’s picture

scott_euser commented
Assigned: scott_euser » Unassigned

Composer failure is unrelated to this

scott_euser’s picture

scott_euser commented

Looks like composer failure is related to #3455217: Automated Drupal 11 compatibility fixes for facets which is the case because this module has a dependency on facets.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Version: 4.3.5 » 4.x-dev
Status: Needs review » Needs work

This patch break the entire functionality of "Add new Solr Document fields".
The purpose of that feature is to filter the down the normal "Add field" modal to only offer fields that aren't configured yet.
This feature is entirely removed by the merge request.

To test it, you need a "foreign" Solr index not reflecting Drupal's data. By "adding" fields to the Search API Index you make that data available to be searched within Drupal and to build Views based on that data.

scott_euser’s picture

scott_euser commented
Status: Needs work » Needs review

Fixed as per discussion in Slack; thank you for helping me reproduce the error and understand the purpose. I added a comment to the MR to explain the purpose here for future travellers.

scott_euser’s picture

scott_euser commented

Note that you need to update to the latest MR in #3484811: Improve the Search API admin UI for adding/editing fields if you are rechecking.

  • mkalkbrenner committed 5eac976a on 4.x 
    Issue #3486761 by scott_euser, mkalkbrenner: Prepare for updated add...
mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Needs review » Fixed
scott_euser’s picture

scott_euser commented

Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mkalkbrenner closed merge request !50