Problem/Motivation
phpunit testing has suddenly started failing, without the code having been changed, or even the code against which it is testing being changed.
See also #3486021: Unable to run "composer (previous major)" from pipeline UI; no image which is also causing issues. Related? Has PHP changed, or some version of something?
NB: Cannot be reproduced locally, only on gitlabci testing
Steps to reproduce
Run a test pipeline against a branch or release:
- https://git.drupalcode.org/project/genpass/-/jobs/3277279 ; a failed 2.1.x phpunit test job
- https://git.drupalcode.org/issue/genpass-3486022/-/jobs/3277571 ; another one after adding test without genpass at all
Proposed resolution
Caused by #3485956: Recursion limit exceeded with Twig v3.14.1 when editing a node or a block.
Remaining tasks
- ✅ File an issue
- ✅ Figure out what is wrong
- ✅ Addition/Change/Update/Fix
- ✅ Testing to ensure no regression
User interface changes
- unknown
API changes
- unknown
Data model changes
- unknown
Release notes snippet
- #3486022: Test to check Drupal working and installing genpass.
Issue fork genpass-3486022
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
elc commentedWithout Generate Password event installed, testing is unable to access admin/config/people/accounts in current or next minor.
From the new NotInstalledTest.php =>
Comment #3
elc commentedAll tests work perfectly locally so this is only on the testing infrastructure that things are broken.
Comment #4
elc commentedThe act of logging into drupal as an administrator with
['administer account settings', 'administer users']and accessing$this->drupalGet('admin/config/people/accounts');is causing a 500 error. This should be without genpass installed unless I am mistaken about the$this->modulesarray, from which I have removed genpass. Should check on that.Comment #5
elc commentedAdded to the test; genpass is not installed at the start, and drupal core is still giving 500 error on
admin/config/people/accounts, NOT onadmin.Comment #6
fjgarlin commentedProbably related: https://drupal.slack.com/archives/C2AAKNL13/p1730932164254339
It happens on Core 11.1.x
#3485956: Recursion limit exceeded with Twig v3.14.1 when editing a node or a block
Comment #8
elc commentedForcing twig to 3.14.0 fixes it here, and all the live sites I just dutifully updated just today.
Fix will be done in #3485956: Recursion limit exceeded with Twig v3.14.1 when editing a node or a block.
Comment #10
elc commentedChange of title to reflect the actual change as a result of this isssue; to avoid going down the rabbit hole of suspecting something wrong with the module, make sure that Drupal works before genpass is installed.