Recursion limit exceeded with Twig v3.14.1 when editing a node or a block [#3485956]

Problem/Motivation

Since updating phpstan and twig via Composer, a blank page appears when editing any node.

Enabling xdebug reveals that the new recursive logic in twig is hitting the recursion limit in Drupal render arrays, particularly forms.

Error: Xdebug has detected a possible infinite loop, and aborted your script with a stack depth of '1000' frames in Twig\Extension\SandboxExtension->isSandboxed() (line 56 of /var/www/html/vendor/twig/twig/src/Extension/SandboxExtension.php).

Twig\Extension\SandboxExtension->ensureToStringAllowed() (Line: 124)
Twig\Extension\SandboxExtension->ensureToStringAllowed() (Line: 93)
__TwigTemplate_13b75ab4e98e9076c88c6eb888b04ed5->doDisplay() (Line: 393)
Twig\Template->yield() (Line: 349)
Twig\Template->display() (Line: 364)
Twig\Template->render() (Line: 35)
Twig\TemplateWrapper->render() (Line: 33)
twig_render_template() (Line: 348)
Drupal\Core\Theme\ThemeManager->render() (Line: 446)
Drupal\Core\Render\Renderer->doRender() (Line: 459)
Drupal\Core\Render\Renderer->doRender() (Line: 459)
Drupal\Core\Render\Renderer->doRender() (Line: 203)
Drupal\Core\Render\Renderer->render() (Line: 238)
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 593)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 231)
Drupal\Core\Render\MainContent\HtmlRenderer->prepare() (Line: 128)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse() (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray() (Line: 246)
Symfony\Component\EventDispatcher\EventDispatcher::Symfony\Component\EventDispatcher\{closure}() (Line: 206)
Symfony\Component\EventDispatcher\EventDispatcher->callListeners() (Line: 56)
Symfony\Component\EventDispatcher\EventDispatcher->dispatch() (Line: 188)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 709)
Drupal\Core\DrupalKernel->handle() (Line: 19)

Steps to reproduce

user@server:~/public_html$ composer update -W
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 2 updates, 0 removals
  - Upgrading phpstan/phpstan (1.12.7 => 1.12.8)
  - Upgrading twig/twig (v3.14.0 => v3.14.1)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 2 updates, 0 removals
  - Downloading twig/twig (v3.14.1)
  - Downloading phpstan/phpstan (1.12.8)
  - Upgrading twig/twig (v3.14.0 => v3.14.1): Extracting archive
  - Upgrading phpstan/phpstan (1.12.7 => 1.12.8): Extracting archive
Generating autoload files
48 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found.

Using D10.3.6 with PHP 8.3.13

Proposed resolution

Update twig/twig dependency to 3.14.2 when it is released since 3.14.0 is out-of-date anyway.

Issue fork branches:

- 10.3.x: 3485956-11.3.x
- 10.4.x: 3485956-11.4.x
- 10.5.x: 3485956-10.5.x
- 11.x: 3485956-recursion-limit-exceeded
- 11.0.x: 3485956-11.0.x
- 11.1.x: 3485956-11.1.x

Remaining tasks

- Update dependency in core.

API changes

Data model changes

Release notes snippet

Comment	File	Size	Author
#34	3485956-twig.diff	1.39 KB	jan kellermann

Issue fork drupal-3485956

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

6 hidden branches

3485956-recursion-limit-exceeded