Closed (fixed)
Project:
OpenID Connect Microsoft Azure Active Directory client
Version:
2.0.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
4 Nov 2024 at 12:25 UTC
Updated:
30 Jan 2025 at 05:49 UTC
Jump to comment: Most recent
Comments
Comment #3
jeroentComment #4
mparker17I have code-reviewed and manually tested the code in merge request !34, and I'm satisfied with it.
Here is what I did to manually-test !34:
git clone --branch '2.0.x' https://git.drupalcode.org/project/openid_connect_windows_aad.git && cd openid_connect_windows_aad- clone the projectgit remote add openid_connect_windows_aad-3485376 https://git.drupalcode.org/issue/openid_connect_windows_aad-3485376.git && git fetch openid_connect_windows_aad-3485376- add a remote for the issue forkgit checkout -b '3485376-drupal-11-support' --track openid_connect_windows_aad-3485376/'3485376-drupal-11-support'- switch to the branch for merge request !34ddev config --project-type=drupal --docroot=web --php-version=8.3 --corepack-enable --project-name=openid-connect-windows-aadddev add-on get ddev/ddev-drupal-contrib && ddev start && ddev poser && ddev symlink-project- run the setup steps for the ddev/ddev-drupal-contrib addoncd web/modules/contrib/openid_connect && curl -OL https://www.drupal.org/files/issues/2024-11-11/openid_connect-3486049-6.patch && patch -p1 < openid_connect-3486049-6.patch && cd -https://openid-connect-windows-aad.ddev.site/core/install.phpin a browser. Confirm that I saw the Drupal 11.0.9 installer. Install the site with the "Standard" install profile/admin/modulesand enable theopenid_connect_windows_aadmodule and its dependencies/admin/config/people/openid-connect/settingsand set the following options: (if you get an error when visiting this URL, don't forget to patch openid_connect with #3486049-6: 'Settings' option not accessible to fix the bug in that module)Above... then click Save configuration.
/admin/config/people/accounts, and set Who can register accounts? toVisitors, then click Save configuration. (warning: you probably don't want to use this setting on a real site, but it's good enough to test openid_connect_windows_aad's basic functionality in D11)https://portal.azure.comand log in if needed. Go to the hamburger menu -> All services. Under Identity, click Microsoft Entra IDopenid-connect-windows-aad-drupal11-testWebhttps://openid-connect-windows-aad.ddev.site/openid-connect/azure_oidc_d11_test... then click Register.
https://portal.azure.comagain. Go to the hamburger menu -> All services. Under Identity, click Microsoft Entra IDtestd11and Expires =90 days (3 months). Click Add. Copy the Value./admin/config/system/keys/add, enter:oidc_entra_app_keyEncryptionOther320Configuration... click Save. You see the message The key oidc_entra_app_key has been added.
/admin/config/people/openid-connect/add/windows_aad. You see a Add OpenID Connect client form. Enter:azure_oidc_d11_test... don't submit the form yet...
https://login.microsoftonline.comAlternate or no user endpointsubhttps://openid-connect-windows-aad.ddev.site/openid-connect/azure_oidc_d11_test)... click Create OpenID Connect client. You see the message OpenID Connect client azure_oidc_d11_test has been added.
/admin/config/development/performanceclick Clear all caches/user/login. You should see a Log in with azure_oidc_d11_test button above the Username and Password fields.test_editoruser created earlier; and log in as the administrator again/admin/reports/dblogto ensure our setup/testing did not result in any error messages related to this module.Comment #7
fabianderijkThis is now merged in the dev branch. Thanks for the work.
Comment #8
dpiCould we get a new @beta release including this one <3