Problem/Motivation

  • Showing username is security problem as usernames should never shown on websites. With real names you cannot login and try passwords, with a username you can. See https://www.drupal.org/project/drupal/issues/3241232
  • Some sites are keeping the username internally
  • We should ALWAYS show display name instead of username

Proposed resolution

Fix it everywhere. Probably, the user selection widget is more difficult and should not be in the scope of this issue (see #2987189: Realname support)

Remaining tasks

None.

User interface changes

Users will see the display name rather than the username on UIs (except user selection autocomplete that will be handled in a followup)

API changes

None.

Data model changes

None.

Issue fork private_message-3484561

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea opened merge request !133

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Title: Show user display name instead of username everywhere » [PP-1] Show user display name instead of username everywhere

This is postponed on #3482504: Fix test pipeline issues

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Active » Postponed
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Title: [PP-1] Show user display name instead of username everywhere » Show user display name instead of username everywhere

#3482504: Fix test pipeline issues is merged

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Postponed » Active
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Active » Needs review

Ready for review. Note that in some places, especially in tests, we're still using ::getAccountName() because that belongs to user selector widget and fixing that is not in the scope of this issue.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Related issues: +#3484915: Unify verb: ban/unban -> block/unblock

While working on this I've opened #3484915: Unify verb: ban/unban -> block/unblock as a followup.

dxvargas’s picture

dxvargas commented

The user display name is being shown instead of the username everywhere (except user selection autocomplete as mentioned in the issue's description). The code is good with many nice improvements. I mark as RTBC.

dxvargas’s picture

dxvargas commented
Status: Needs review » Reviewed & tested by the community

  • claudiu.cristea committed ee70308e on 3.0.x 
    Issue #3484561 by claudiu.cristea, dxvargas: Show user display name...
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Reviewed & tested by the community » Fixed

Thank you for review

claudiu.cristea opened merge request !156

claudiu.cristea closed merge request !156

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.