Closed (fixed)
Project:
Search API
Version:
8.x-1.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
29 Oct 2024 at 10:29 UTC
Updated:
8 Dec 2024 at 11:39 UTC
Jump to comment: Most recent
Comments
Comment #3
a.dmitriiev commentedComment #4
borisson_Looks super simple in code, I think we should just do this.
Comment #5
drunken monkeyI agree with @borisson_, this looks great. Thanks!
Merged. Thanks again!
Comment #7
drunken monkeyComment #10
thejimbirch commentedThis is so cool! I believe this is the first contib config action.
1. As a general best practice in recipes, we strive to make recipes/config actions non-destructive. Will removeDatasource, removeProcessor, and removeField present the possibility of a recipe breaking a site? What would those actions be used for?
2. Could we get a change order for this issue? As the first config actions in the contrib space. It would help with documentation in the Recipes Initiative and set precedent for other contrib modules to follow.
Something like this (Note: I am not sure that is how the actions work)
Comment #11
borisson_I think this issue was supposed to be marked as fixed?
Comment #12
drunken monkeyYes, those all have the potential to break a site or cause security problems.
That doesn’t seem like something we normally use change records for, as it’s just a new functionality.
Wouldn’t a documentation page make more sense? I’d support adding a page to our existing documentation, maybe under “Developer documentation”. However, I don’t think I understand recipes and config actions enough to write this myself.