Problem/Motivation

Let's add support for attributes.

Issue fork jsonapi_extras-3483948

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ptmkenny created an issue. See original summary.

ptmkenny opened merge request !61

ptmkenny’s picture

ptmkenny commented
Status: Active » Needs review

I ported the annotation, but I removed "class" because attributes already have that.

ptmkenny’s picture

ptmkenny commented

Forgot to wire up the attribute; that's fixed now and I think this is ready to go.

bbrala’s picture

bbrala
Location Netherlands
commented

Thanks for this.

I wonder if we should to the BC way, supporting both annotaatinos and attributes. But perhaps since we are the source of the manager only supporting getting things by annotations is fine. Do you agree?

ptmkenny’s picture

ptmkenny commented

The annotation class is still there, so annotations are still supported for people who have written their own plugins on top of JSON:API Extras and are using annotations.

As for the plugins in this module, it is fine to convert them to attributes now because the module's composer.json already has "php": ">=8.1", so attributes will definitely be supported (attribute support is from 8.1). So I don't think this should break anything for anyone.

  • bbrala committed 4dd2d8f7 on 8.x-3.x authored by ptmkenny 
    Issue #3483948 by ptmkenny, bbrala: Add support for attributes
bbrala’s picture

bbrala
Location Netherlands
commented
Status: Needs review » Fixed

Yeah same cocnclusion here. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.