Problem/Motivation

In #3470540: Create some front-end components to render filters defined by the source we found that somewhere in the code we have hard coded the tab index for each filter and because of this there is a restriction occurring that the order of the defined source filters should be categories -> security coverage -> maintenance status -> development status which is not correct.

Steps to reproduce

Proposed resolution

Remove the hard coded tab index for the filters. Maybe the solution could be that the tab index is dynamically set according to the order in which source filters are defined.

Issue fork project_browser-3483412

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kunal.sachdev created an issue. See original summary.

kunal.sachdev’s picture

kunal.sachdev commented
Related issues: +#3470540: Create some front-end components to render filters defined by the source
chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Issue tags: +core-mvp, +beta blocker

utkarsh_33 made their first commit to this issue’s fork.

utkarsh_33 opened merge request !638

utkarsh_33’s picture

utkarsh_33 commented
Status: Active » Needs review

This is ready for review.The CI(Eslint) is failing on all the branches so that can be ignored.Marking it NR.

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Needs review » Reviewed & tested by the community

Changes look good to me. Just a small nit to address. Tested manually, and the filters are working as they did on 2.0.x.

utkarsh_33’s picture

utkarsh_33 commented

Merged the latest changes from 2.0.x.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Reviewed & tested by the community » Fixed

Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.